From: Christoph Hellwig <hch@infradead.org>
To: Kees Cook <keescook@chromium.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Christoph Hellwig <hch@infradead.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Converting struct timer_list callback argument to struct timer_list *
Date: Fri, 1 Sep 2017 03:08:38 -0700 [thread overview]
Message-ID: <20170901100838.GA8891@infradead.org> (raw)
In-Reply-To: <CAGXu5j+hFe3jrxqSoPS06XdEeEURQiQ4pWWdqoHbUgWhj+cE2w@mail.gmail.com>
Good work!
I just think that the TIMER_CONTAINER name is revolting.
The usual name for such a helper fitting other uses like lists
and rbtrees would be timer_entry, and that also reads much better.
next prev parent reply other threads:[~2017-09-01 10:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 23:39 Converting struct timer_list callback argument to struct timer_list * Kees Cook
2017-08-31 20:13 ` Thomas Gleixner
2017-08-31 23:32 ` Kees Cook
2017-09-01 10:08 ` Christoph Hellwig [this message]
2017-09-01 10:21 ` Thomas Gleixner
2017-09-01 10:44 ` Christoph Hellwig
2017-09-01 16:24 ` Kees Cook
2017-09-03 7:37 ` Christoph Hellwig
2017-09-03 20:18 ` Kees Cook
2017-09-04 6:07 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170901100838.GA8891@infradead.org \
--to=hch@infradead.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox