From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751880AbdIAKUh (ORCPT <rfc822;w@1wt.eu>);
        Fri, 1 Sep 2017 06:20:37 -0400
Received: from verein.lst.de ([213.95.11.211]:59986 "EHLO newverein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751794AbdIAKUf (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 1 Sep 2017 06:20:35 -0400
Date: Fri, 1 Sep 2017 12:20:34 +0200
From: Christoph Hellwig <hch@lst.de>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Christoph Hellwig <hch@lst.de>, arve@android.com,
        riandrews@android.com, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/16] ashmem: switch to ->read_iter
Message-ID: <20170901102034.GA25178@lst.de>
References: <20170830150007.3953-1-hch@lst.de> <20170830150007.3953-2-hch@lst.de> <20170830152855.GL5426@ZenIV.linux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170830152855.GL5426@ZenIV.linux.org.uk>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Aug 30, 2017 at 04:28:55PM +0100, Al Viro wrote:
> On Wed, Aug 30, 2017 at 04:59:52PM +0200, Christoph Hellwig wrote:
> > And use the proper VFS helper for using the backing file.
> 
> Actually, I wonder if that update of ->f_pos of the underlying file is
> correct.  That's unrelated to this patch, but might be worth sorting
> out while we are at it.

Sure, I'll add that.  If ashmem_mutex wasn't a global lock we could
just as easily keep it locked, but I'll leave that to the android
folks.