From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751974AbdIAKhI (ORCPT ); Fri, 1 Sep 2017 06:37:08 -0400 Received: from verein.lst.de ([213.95.11.211]:60037 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751794AbdIAKhH (ORCPT ); Fri, 1 Sep 2017 06:37:07 -0400 Date: Fri, 1 Sep 2017 12:37:05 +0200 From: Christoph Hellwig To: Al Viro Cc: Christoph Hellwig , arve@android.com, riandrews@android.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/16] fs: fix kernel_read prototype Message-ID: <20170901103705.GC25178@lst.de> References: <20170830150007.3953-1-hch@lst.de> <20170830150007.3953-6-hch@lst.de> <20170830153704.GN5426@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170830153704.GN5426@ZenIV.linux.org.uk> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 30, 2017 at 04:37:04PM +0100, Al Viro wrote: > On Wed, Aug 30, 2017 at 04:59:56PM +0200, Christoph Hellwig wrote: > > Use proper ssize_t and size_t types for the return value and count > > argument, move the offset last and make it an in/out argument like > > all other read/write helpers. > > Might be better to switch the third argument to void * at the same time > and lose those casts. Good point, updated. > > > if (p) > > memcpy(p + offset, buf, n); > > - > > - offset += n; > > Almost certainly broken - in effect, you've taken the update of offset > several lines prior, so that memcpy() is getting the wrong first argument. > The same needs to be watched out for in other similar places. Fixed. I did an audit and didn't find any others either for kernel_read or kernel_write.