From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751968AbdIAKlo (ORCPT <rfc822;w@1wt.eu>);
        Fri, 1 Sep 2017 06:41:44 -0400
Received: from verein.lst.de ([213.95.11.211]:60080 "EHLO newverein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751725AbdIAKlm (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 1 Sep 2017 06:41:42 -0400
Date: Fri, 1 Sep 2017 12:41:41 +0200
From: Christoph Hellwig <hch@lst.de>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Christoph Hellwig <hch@lst.de>, arve@android.com,
        riandrews@android.com, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 08/16] mm/nommu: switch do_mmap_private to kernel_read
Message-ID: <20170901104141.GE25178@lst.de>
References: <20170830150007.3953-1-hch@lst.de> <20170830150007.3953-9-hch@lst.de> <20170830154128.GP5426@ZenIV.linux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170830154128.GP5426@ZenIV.linux.org.uk>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Aug 30, 2017 at 04:41:28PM +0100, Al Viro wrote:
> On Wed, Aug 30, 2017 at 04:59:59PM +0200, Christoph Hellwig wrote:
> > -		fpos = vma->vm_pgoff;
> > -		fpos <<= PAGE_SHIFT;
> 
> > +		loff_t fpos = vma->vm_pgoff << PAGE_SHIFT;
> 
> Umm...  Are you sure it's OK on 32bit hosts?

It's not.  Fixed.