From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751932AbdIAKpA (ORCPT ); Fri, 1 Sep 2017 06:45:00 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:57174 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751825AbdIAKo7 (ORCPT ); Fri, 1 Sep 2017 06:44:59 -0400 Date: Fri, 1 Sep 2017 03:44:56 -0700 From: Christoph Hellwig To: Thomas Gleixner Cc: Christoph Hellwig , Kees Cook , LKML Subject: Re: Converting struct timer_list callback argument to struct timer_list * Message-ID: <20170901104456.GA25892@infradead.org> References: <20170901100838.GA8891@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 01, 2017 at 12:21:46PM +0200, Thomas Gleixner wrote: > On Fri, 1 Sep 2017, Christoph Hellwig wrote: > > > Good work! > > > > I just think that the TIMER_CONTAINER name is revolting. > > > > The usual name for such a helper fitting other uses like lists > > and rbtrees would be timer_entry, and that also reads much better. > > I think the plan is to remove that thing afterward, because then the > callback function is: > > void func(struct timer_list *timer) > > So I don't mind the ugly name as it should be simply removed once the tree > is converted over. Well, we can't just remove it, we could just replace it with container_of(). lists and rbtrees just keep their list_entry and rb_entry wrappers for timer_of, so we could save us the additional churn by naming it timer_entry and just keeping it.