From: Andrew Lunn <andrew@lunn.ch>
To: Antoine Tenart <antoine.tenart@free-electrons.com>
Cc: davem@davemloft.net, gregory.clement@free-electrons.com,
thomas.petazzoni@free-electrons.com, nadavh@marvell.com,
linux@armlinux.org.uk, linux-kernel@vger.kernel.org,
mw@semihalf.com, stefanc@marvell.com,
miquel.raynal@free-electrons.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/4] net: mvpp2: make the phy optional
Date: Fri, 1 Sep 2017 15:34:34 +0200 [thread overview]
Message-ID: <20170901133434.GX22289@lunn.ch> (raw)
In-Reply-To: <20170901090455.32316-3-antoine.tenart@free-electrons.com>
On Fri, Sep 01, 2017 at 11:04:53AM +0200, Antoine Tenart wrote:
> There is not necessarily a PHY between the GoP and the physical port.
> However, the driver currently makes the "phy" property mandatory,
> contrary to what is stated in the device tree bindings. This patch makes
> the PHY optional, and aligns the PPv2 driver on its device tree
> documentation. However if a PHY is provided, the GoP link interrupt
> won't be used.
>
> With this patch switches directly connected to the serdes lanes and SFP
> ports on the Armada 8040-db and Armada 7040-db can be used if the link
> interrupt is described in the device tree.
>
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> Tested-by: Marcin Wojtas <mw@semihalf.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2017-09-01 13:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 9:04 [PATCH net-next v2 0/4] net: mvpp2: optional PHYs and GoP link irq Antoine Tenart
2017-09-01 9:04 ` [PATCH net-next v2 1/4] net: mvpp2: take advantage of the is_rgmii helper Antoine Tenart
2017-09-01 13:33 ` Andrew Lunn
2017-09-01 9:04 ` [PATCH net-next v2 2/4] net: mvpp2: make the phy optional Antoine Tenart
2017-09-01 13:34 ` Andrew Lunn [this message]
2017-09-01 9:04 ` [PATCH net-next v2 3/4] net: mvpp2: use the GoP interrupt for link status changes Antoine Tenart
2017-09-01 9:04 ` [PATCH net-next v2 4/4] Documentation/bindings: net: marvell-pp2: add the link interrupt Antoine Tenart
2017-09-01 13:35 ` Andrew Lunn
2017-09-01 17:09 ` [PATCH net-next v2 0/4] net: mvpp2: optional PHYs and GoP link irq David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170901133434.GX22289@lunn.ch \
--to=andrew@lunn.ch \
--cc=antoine.tenart@free-electrons.com \
--cc=davem@davemloft.net \
--cc=gregory.clement@free-electrons.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=miquel.raynal@free-electrons.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=stefanc@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox