From: Stephen Hemminger <stephen@networkplumber.org>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH iproute2 0/2] fix "ip link show dev ..." for NICs with many VFs
Date: Fri, 1 Sep 2017 14:16:39 -0700 [thread overview]
Message-ID: <20170901141639.2f77d60f@xeon-e3> (raw)
In-Reply-To: <cover.1504283683.git.mkubecek@suse.cz>
On Fri, 1 Sep 2017 18:39:06 +0200 (CEST)
Michal Kubecek <mkubecek@suse.cz> wrote:
> Two of our customers recently encountered problems with processing of large
> messages produced by kernel in response to "ip link show" for NICs with
> many (120-128) virtual functions. While some of them have been already
> addressed in recent versions of iproute2, some still persist.
>
> Patch 1 adds check to handle the case when a message fits into the
> buffer in rtnl_talk() but not into the buffer in iplink_get().
>
> Patch 2 increases the buffer size in iplink_get() to suffice even for
> NICs with 128 VFs.
>
> Note: after applying patch 2, patch 1 seems useless as both buffers have
> the same size so that the check cannot actually trigger. However, as we
> cannot guarantee they will always stay the same, I believe the check
> should still be added.
>
> Michal Kubecek (2):
> iplink: check for message truncation in iplink_get()
> iplink: double the buffer size also in iplink_get()
>
> ip/iplink.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
Looks like the best set of solutions to the kernel side API issue.
Applied, thanks Michal.
prev parent reply other threads:[~2017-09-01 21:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 16:39 [PATCH iproute2 0/2] fix "ip link show dev ..." for NICs with many VFs Michal Kubecek
2017-09-01 16:39 ` [PATCH iproute2 1/2] iplink: check for message truncation in iplink_get() Michal Kubecek
2017-09-01 16:39 ` [PATCH iproute2 2/2] iplink: double the buffer size also " Michal Kubecek
2017-09-01 21:16 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170901141639.2f77d60f@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox