* [PATCH] f2fs: avoid needless inode updates
@ 2017-09-02 0:05 Jaegeuk Kim
2017-09-02 1:05 ` Jaegeuk Kim
0 siblings, 1 reply; 2+ messages in thread
From: Jaegeuk Kim @ 2017-09-02 0:05 UTC (permalink / raw)
To: linux-kernel, linux-fsdevel, linux-f2fs-devel; +Cc: Jaegeuk Kim
If i_size wan't change at all, we don't need to write inode during fsync.
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
fs/f2fs/f2fs.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index 4b993961d81d..0d76b572484a 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -2267,11 +2267,11 @@ static inline bool f2fs_skip_inode_update(struct inode *inode, int dsync)
spin_unlock(&sbi->inode_lock[DIRTY_META]);
return ret;
}
- if (!is_inode_flag_set(inode, FI_AUTO_RECOVER) ||
- file_keep_isize(inode) ||
- i_size_read(inode) & PAGE_MASK)
- return false;
- return F2FS_I(inode)->last_disk_size == i_size_read(inode);
+ if (F2FS_I(inode)->last_disk_size == i_size_read(inode))
+ return true;
+
+ return is_inode_flag_set(inode, FI_AUTO_RECOVER) &&
+ !file_keep_isize(inode) && !(i_size_read(inode) & PAGE_MASK);
}
static inline int f2fs_readonly(struct super_block *sb)
--
2.14.0.rc1.383.gd1ce394fe2-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] f2fs: avoid needless inode updates
2017-09-02 0:05 [PATCH] f2fs: avoid needless inode updates Jaegeuk Kim
@ 2017-09-02 1:05 ` Jaegeuk Kim
0 siblings, 0 replies; 2+ messages in thread
From: Jaegeuk Kim @ 2017-09-02 1:05 UTC (permalink / raw)
To: linux-kernel, linux-fsdevel, linux-f2fs-devel
Please ignore this patch.
Thanks,
On 09/01, Jaegeuk Kim wrote:
> If i_size wan't change at all, we don't need to write inode during fsync.
>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
> fs/f2fs/f2fs.h | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> index 4b993961d81d..0d76b572484a 100644
> --- a/fs/f2fs/f2fs.h
> +++ b/fs/f2fs/f2fs.h
> @@ -2267,11 +2267,11 @@ static inline bool f2fs_skip_inode_update(struct inode *inode, int dsync)
> spin_unlock(&sbi->inode_lock[DIRTY_META]);
> return ret;
> }
> - if (!is_inode_flag_set(inode, FI_AUTO_RECOVER) ||
> - file_keep_isize(inode) ||
> - i_size_read(inode) & PAGE_MASK)
> - return false;
> - return F2FS_I(inode)->last_disk_size == i_size_read(inode);
> + if (F2FS_I(inode)->last_disk_size == i_size_read(inode))
> + return true;
> +
> + return is_inode_flag_set(inode, FI_AUTO_RECOVER) &&
> + !file_keep_isize(inode) && !(i_size_read(inode) & PAGE_MASK);
> }
>
> static inline int f2fs_readonly(struct super_block *sb)
> --
> 2.14.0.rc1.383.gd1ce394fe2-goog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-02 1:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-02 0:05 [PATCH] f2fs: avoid needless inode updates Jaegeuk Kim
2017-09-02 1:05 ` Jaegeuk Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox