From: Leo Yan <leo.yan@linaro.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: rui.zhang@intel.com, edubezval@gmail.com,
linux-pm@vger.kernel.org, kevin.wangtao@linaro.org,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 11/13] thermal/drivers/hisi: Convert long to int
Date: Sat, 2 Sep 2017 11:41:56 +0800 [thread overview]
Message-ID: <20170902034156.GD3841@leoy-linaro> (raw)
In-Reply-To: <1504082857-21702-11-git-send-email-daniel.lezcano@linaro.org>
On Wed, Aug 30, 2017 at 10:47:35AM +0200, Daniel Lezcano wrote:
> There is no point to specify the temperature as long variable, the int is
> enough.
>
> Replace all long variables to int, so making the code consistent.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Reviewed-by: Leo Yan <leo.yan@linaro.org>
> ---
> drivers/thermal/hisi_thermal.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_thermal.c
> index 68b625c..9eee82b 100644
> --- a/drivers/thermal/hisi_thermal.c
> +++ b/drivers/thermal/hisi_thermal.c
> @@ -83,12 +83,12 @@ static inline int hisi_thermal_step_to_temp(int step)
> return HISI_TEMP_BASE + (step * HISI_TEMP_STEP);
> }
>
> -static inline long hisi_thermal_temp_to_step(long temp)
> +static inline int hisi_thermal_temp_to_step(int temp)
> {
> return (temp - HISI_TEMP_BASE) / HISI_TEMP_STEP;
> }
>
> -static inline long hisi_thermal_round_temp(int temp)
> +static inline int hisi_thermal_round_temp(int temp)
> {
> return hisi_thermal_step_to_temp(
> hisi_thermal_temp_to_step(temp));
> --
> 2.7.4
>
next prev parent reply other threads:[~2017-09-02 3:42 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 8:47 [PATCH 01/13] thermal/drivers/hisi: Fix missing interrupt enablement Daniel Lezcano
2017-08-30 8:47 ` [PATCH 02/13] thermal/drivers/hisi: Remove the multiple sensors support Daniel Lezcano
2017-09-01 14:05 ` Leo Yan
2017-09-01 20:48 ` Daniel Lezcano
2017-08-30 8:47 ` [PATCH 03/13] thermal/drivers/hisi: Fix kernel panic on alarm interrupt Daniel Lezcano
2017-09-01 14:14 ` Leo Yan
2017-08-30 8:47 ` [PATCH 04/13] thermal/drivers/hisi: Simplify the temperature/step computation Daniel Lezcano
2017-09-01 14:24 ` Leo Yan
2017-08-30 8:47 ` [PATCH 05/13] thermal/drivers/hisi: Fix multiple alarm interrupts firing Daniel Lezcano
2017-09-01 14:40 ` Leo Yan
2017-08-30 8:47 ` [PATCH 06/13] thermal/drivers/hisi: Remove pointless lock Daniel Lezcano
2017-09-01 14:44 ` Leo Yan
2017-08-30 8:47 ` [PATCH 07/13] thermal/drivers/hisi: Encapsulate register writes into helpers Daniel Lezcano
2017-09-02 2:09 ` Leo Yan
2017-09-02 2:17 ` Leo Yan
2017-08-30 8:47 ` [PATCH 08/13] thermal/drivers/hisi: Fix configuration register setting Daniel Lezcano
2017-09-02 2:54 ` Leo Yan
2017-09-02 8:34 ` Daniel Lezcano
2017-09-04 0:58 ` Leo Yan
2017-09-04 9:16 ` Daniel Lezcano
2017-08-30 8:47 ` [PATCH 09/13] thermal/drivers/hisi: Remove costly sensor inspection Daniel Lezcano
2017-09-02 3:29 ` Leo Yan
2017-09-02 13:10 ` Daniel Lezcano
2017-09-04 0:50 ` Leo Yan
2017-09-04 11:29 ` Daniel Lezcano
2017-09-04 14:30 ` Leo Yan
2017-08-30 8:47 ` [PATCH 10/13] thermal/drivers/hisi: Rename and remove unused field Daniel Lezcano
2017-09-02 3:36 ` Leo Yan
2017-08-30 8:47 ` [PATCH 11/13] thermal/drivers/hisi: Convert long to int Daniel Lezcano
2017-09-02 3:41 ` Leo Yan [this message]
2017-08-30 8:47 ` [PATCH 12/13] thermal/drivers/hisi: Remove thermal data back pointer Daniel Lezcano
2017-08-30 8:47 ` [PATCH 13/13] thermal/drivers/hisi: Remove mutex_lock in the code Daniel Lezcano
2017-09-02 4:04 ` Leo Yan
2017-09-02 13:11 ` Daniel Lezcano
2017-09-01 8:31 ` [PATCH 01/13] thermal/drivers/hisi: Fix missing interrupt enablement Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170902034156.GD3841@leoy-linaro \
--to=leo.yan@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=kevin.wangtao@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox