From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752933AbdICOL1 (ORCPT ); Sun, 3 Sep 2017 10:11:27 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:36047 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752868AbdICOLZ (ORCPT ); Sun, 3 Sep 2017 10:11:25 -0400 X-Google-Smtp-Source: ADKCNb7Qx59a+YTgPaY+fqv6EH7rEXXiUvtKDjxG8OxX+lBlFedXBjX0+sNp47VtA3hbiqk7xtNXJA== Date: Sun, 3 Sep 2017 22:11:22 +0800 From: Wang YanQing To: tiwai@suse.de Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH] ALSA: hda: Fix forget to free resource in error handling code path in hda_codec_driver_probe Message-ID: <20170903141122.GA2848@udknight> Mail-Followup-To: Wang YanQing , tiwai@suse.de, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When hda_codec_driver_probe meet error and return failure, we need to free resource with patch_ops.free, or we will get resource leak. Signed-off-by: Wang YanQing --- sound/pci/hda/hda_bind.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/pci/hda/hda_bind.c b/sound/pci/hda/hda_bind.c index 6efadbf..f1b1b7e 100644 --- a/sound/pci/hda/hda_bind.c +++ b/sound/pci/hda/hda_bind.c @@ -123,6 +123,8 @@ static int hda_codec_driver_probe(struct device *dev) module_put(owner); error: + if (codec->patch_ops.free) + codec->patch_ops.free(codec); snd_hda_codec_cleanup_for_unbind(codec); return err; } -- 1.8.5.6.2.g3d8a54e.dirty