From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753135AbdIDGHv (ORCPT ); Mon, 4 Sep 2017 02:07:51 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:40574 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751633AbdIDGHu (ORCPT ); Mon, 4 Sep 2017 02:07:50 -0400 Date: Sun, 3 Sep 2017 23:07:48 -0700 From: Christoph Hellwig To: Kees Cook Cc: Christoph Hellwig , Thomas Gleixner , LKML Subject: Re: Converting struct timer_list callback argument to struct timer_list * Message-ID: <20170904060748.GC31083@infradead.org> References: <20170901100838.GA8891@infradead.org> <20170901104456.GA25892@infradead.org> <20170903073757.GA28985@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 03, 2017 at 01:18:44PM -0700, Kees Cook wrote: > It feels weird to have different semantics from container_of() too, so > I'll probably just switch everything around to be like all the others, > in that they are just direct wrappers around container_of()... I'll > settle on something and switch everything over. I really like the idea of passing in a variable and not the type, though. Maybe we need to add a new generic helper for that, I just can't think of a good name.