From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753976AbdIDRxi (ORCPT ); Mon, 4 Sep 2017 13:53:38 -0400 Received: from mail-pf0-f181.google.com ([209.85.192.181]:36366 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753913AbdIDRxg (ORCPT ); Mon, 4 Sep 2017 13:53:36 -0400 X-Google-Smtp-Source: ADKCNb5/mCcT+tuyZK7XCjZSURp4lAMNKeFAdhrF0KSXhPrVV0sWCQzOcghGSxN30iuUTcF1ENfSZg== Date: Mon, 4 Sep 2017 10:53:33 -0700 From: Bjorn Andersson To: Colin King Cc: Ohad Ben-Cohen , linux-remoteproc@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rpmsg: glink: initialize ret to zero to ensure error status check is correct Message-ID: <20170904175333.GI20643@builder> References: <20170903130601.6533-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170903130601.6533-1-colin.king@canonical.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun 03 Sep 06:06 PDT 2017, Colin King wrote: > From: Colin Ian King > > The new switch cases for RPM_CMD_RX_DONE, RPM_CMD_RX_DONE_W_REUSE, > RPM_CMD_RX_INTENT_REQ_ACK, RPM_CMD_INTENT and RPM_CMD_RX_INTENT_REQ from > 4 recent commits are not setting ret and so a later non-zero check on ret > is testing on a garbage value in ret. Fix this by initializing ret to zero. > > Detected by CoverityScan CID#1455249 ("Uninitialized scalar variable") > > Fixes: 933b45da5d1d ("rpmsg: glink: Add support for TX intents) > Fixes: dacbb35e930f ("glink: Receive and store the remote intent buffers") > Fixes: 27b9c5b66b23 ("rpmsg: glink: Request for intents when unavailable") > Fixes: 88c6060f5a7f ("rpmsg: glink: Handle remote rx done command") > Signed-off-by: Colin Ian King Thanks Colin, applied both patches. Regards, Bjorn > --- > drivers/rpmsg/qcom_glink_native.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c > index 8bc0d0456a40..5a5e927ea50f 100644 > --- a/drivers/rpmsg/qcom_glink_native.c > +++ b/drivers/rpmsg/qcom_glink_native.c > @@ -957,7 +957,7 @@ static irqreturn_t qcom_glink_native_intr(int irq, void *data) > unsigned int param2; > unsigned int avail; > unsigned int cmd; > - int ret; > + int ret = 0; > > for (;;) { > avail = qcom_glink_rx_avail(glink); > @@ -994,8 +994,6 @@ static irqreturn_t qcom_glink_native_intr(int irq, void *data) > > mbox_send_message(glink->mbox_chan, NULL); > mbox_client_txdone(glink->mbox_chan, 0); > - > - ret = 0; > break; > case RPM_CMD_INTENT: > qcom_glink_handle_intent(glink, param1, param2, avail); > -- > 2.14.1 >