public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Cyril Bur <cyrilbur@gmail.com>
Cc: Jassi Brar <jassisinghbrar@gmail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	openbmc@lists.ozlabs.org, Joel Stanley <joel.stan@gmail.com>
Subject: Re: [PATCH v2] drivers/mailbox: Add Aspeed mailbox driver
Date: Tue, 5 Sep 2017 08:25:10 +0200	[thread overview]
Message-ID: <20170905062510.GA16418@kroah.com> (raw)
In-Reply-To: <1504568239.7626.1.camel@gmail.com>

On Tue, Sep 05, 2017 at 09:37:19AM +1000, Cyril Bur wrote:
> On Mon, 2017-09-04 at 20:13 +0530, Jassi Brar wrote:
> > On Mon, Sep 4, 2017 at 12:47 PM, Cyril Bur <cyrilbur@gmail.com> wrote:
> > > Hi,
> > > 
> > > I haven't heard anything about this driver. I'm trying to interpret if
> > > the silence is because there is something fundamentally wrong with the
> > > driver or is it because it doesn't use any of the mailbox
> > > infrastructure it is being ignored.
> > > 
> > 
> > Its the latter.
> 
> Great! Thanks for your response, I'll resend it under char/misc.

Wait, no, please use the mailbox infrastructure for this, making a
one-off char/misc driver isn't ok when there is a framework for you to
use.

thanks,

greg k-h

  reply	other threads:[~2017-09-05  6:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-07 23:36 [PATCH v2] drivers/mailbox: Add Aspeed mailbox driver Cyril Bur
2017-02-09  4:39 ` Joel Stanley
2017-05-03  8:02   ` Suraj Jitindar Singh
2017-09-04  7:17 ` Cyril Bur
2017-09-04 14:43   ` Jassi Brar
2017-09-04 23:37     ` Cyril Bur
2017-09-05  6:25       ` Greg KH [this message]
2017-09-05  7:10         ` Cyril Bur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170905062510.GA16418@kroah.com \
    --to=greg@kroah.com \
    --cc=cyrilbur@gmail.com \
    --cc=jassisinghbrar@gmail.com \
    --cc=joel.stan@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openbmc@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox