From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751551AbdIEJMY (ORCPT ); Tue, 5 Sep 2017 05:12:24 -0400 Received: from foss.arm.com ([217.140.101.70]:36820 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751017AbdIEJMX (ORCPT ); Tue, 5 Sep 2017 05:12:23 -0400 Date: Tue, 5 Sep 2017 10:10:51 +0100 From: Mark Rutland To: chengjian c00427203 Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will.deacon@arm.com, huawei.libin@huawei.com, akpm@linux-foundation.org, mingo@kernel.org Subject: Re: [PATCH] arm64: Convert pr_warning to standard pr_warn Message-ID: <20170905091051.GA4401@leverpostej> References: <1504578518-77544-1-git-send-email-cj.chengjian@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504578518-77544-1-git-send-email-cj.chengjian@huawei.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 05, 2017 at 10:28:38AM +0800, chengjian c00427203 wrote: > Convert pr_warning to standard pr_warn in arch/arm64/kernel/smp.c > > Signed-off-by: Cheng Jian > --- > arch/arm64/kernel/smp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Is this a step towards removing pr_warning entirely? If so, can you please fix up all occurences in arm64? i.e. [mark@leverpostej:~/src/linux]% git grep pr_warning linux-next/master:arch/arm64 linux-next/master:arch/arm64:include/asm/syscall.h: pr_warning("%s called with max args %d, handling only %d\n", linux-next/master:arch/arm64:include/asm/syscall.h: pr_warning("%s called with max args %d, handling only %d\n", linux-next/master:arch/arm64:kernel/hw_breakpoint.c: pr_warning("unknown slot type: %d\n", type); linux-next/master:arch/arm64:kernel/hw_breakpoint.c: pr_warning("attempt to read from unknown breakpoint register %d\n", n); linux-next/master:arch/arm64:kernel/hw_breakpoint.c: pr_warning("attempt to write to unknown breakpoint register %d\n", n); linux-next/master:arch/arm64:kernel/hw_breakpoint.c: pr_warning("invalid breakpoint privilege level %d\n", privilege); linux-next/master:arch/arm64:kernel/smp.c: pr_warning("SMP: failed to stop secondary CPUs %*pbl\n", linux-next/master:arch/arm64:kernel/smp.c: pr_warning("SMP: failed to stop secondary CPUs %*pbl\n", Otherwise, I don't think it make sense to only fix some occurences. Thanks, Mark. > > diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c > index 9f7195a..efcaa05 100644 > --- a/arch/arm64/kernel/smp.c > +++ b/arch/arm64/kernel/smp.c > @@ -972,7 +972,7 @@ void smp_send_stop(void) > udelay(1); > > if (num_online_cpus() > 1) > - pr_warning("SMP: failed to stop secondary CPUs %*pbl\n", > + pr_warn("SMP: failed to stop secondary CPUs %*pbl\n", > cpumask_pr_args(cpu_online_mask)); > } > > @@ -1009,7 +1009,7 @@ void crash_smp_send_stop(void) > udelay(1); > > if (atomic_read(&waiting_for_crash_ipi) > 0) > - pr_warning("SMP: failed to stop secondary CPUs %*pbl\n", > + pr_warn("SMP: failed to stop secondary CPUs %*pbl\n", > cpumask_pr_args(&mask)); > } > > -- > 1.8.3.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel