public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <jdelvare@suse.de>
To: Joe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@canonical.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] checkpatch: simplify the output of --list-types
Date: Tue, 5 Sep 2017 11:37:34 +0200	[thread overview]
Message-ID: <20170905113734.5afafc62@endymion> (raw)
In-Reply-To: <1504540116.28899.1.camel@perches.com>

On Mon, 04 Sep 2017 08:48:36 -0700, Joe Perches wrote:
> On Mon, 2017-09-04 at 10:08 +0200, Jean Delvare wrote:
> > Drop the header and numbering of types. This format was confusing as
> > it suggested one could pass the number instead of the type name,
> > however it did not actually work, and numbering wasn't stable anyway.  
> 
> <shrug>  If it makes you happy.
> 
> I suppose a bigger improvement would be to detail
> the purpose of each type.

That would be great indeed, however this would require a completely
different approach, as I can't think of a way to automatically extract
this information by just parsing the script.

> Most are fairly obvious, some like MEMSET are
> a bit obscure.
> 
> Another defect:
> 
> The list also includes types that are commented out.

This could be considered a feature: if they were not listed, the user
would have no idea that they can be commented out.

OTOH I'm not sure why some tests are commented out in the first place,
it doesn't make much sense to me. Either they serve a purpose and they
should be enabled, or there is some kind of issue with them and they
should be either fixed or deleted altogether.

-- 
Jean Delvare
SUSE L3 Support

      reply	other threads:[~2017-09-05  9:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-04  8:08 [PATCH] checkpatch: simplify the output of --list-types Jean Delvare
2017-09-04 15:48 ` Joe Perches
2017-09-05  9:37   ` Jean Delvare [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170905113734.5afafc62@endymion \
    --to=jdelvare@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=apw@canonical.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox