From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751452AbdIEJhl (ORCPT ); Tue, 5 Sep 2017 05:37:41 -0400 Received: from mx2.suse.de ([195.135.220.15]:54093 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750773AbdIEJhi (ORCPT ); Tue, 5 Sep 2017 05:37:38 -0400 Date: Tue, 5 Sep 2017 11:37:34 +0200 From: Jean Delvare To: Joe Perches Cc: Andy Whitcroft , LKML , Andrew Morton Subject: Re: [PATCH] checkpatch: simplify the output of --list-types Message-ID: <20170905113734.5afafc62@endymion> In-Reply-To: <1504540116.28899.1.camel@perches.com> References: <20170904100824.4cc2410a@endymion> <1504540116.28899.1.camel@perches.com> Organization: SUSE Linux X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 04 Sep 2017 08:48:36 -0700, Joe Perches wrote: > On Mon, 2017-09-04 at 10:08 +0200, Jean Delvare wrote: > > Drop the header and numbering of types. This format was confusing as > > it suggested one could pass the number instead of the type name, > > however it did not actually work, and numbering wasn't stable anyway. > > If it makes you happy. > > I suppose a bigger improvement would be to detail > the purpose of each type. That would be great indeed, however this would require a completely different approach, as I can't think of a way to automatically extract this information by just parsing the script. > Most are fairly obvious, some like MEMSET are > a bit obscure. > > Another defect: > > The list also includes types that are commented out. This could be considered a feature: if they were not listed, the user would have no idea that they can be commented out. OTOH I'm not sure why some tests are commented out in the first place, it doesn't make much sense to me. Either they serve a purpose and they should be enabled, or there is some kind of issue with them and they should be either fixed or deleted altogether. -- Jean Delvare SUSE L3 Support