public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: joe.korty@concurrent-rt.com
To: Sasha Levin <alexander.levin@verizon.com>
Cc: Jesse Gross <jesse@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: tunnels: Don't apply GRO to multiple layers of encapsulation.
Date: Tue, 5 Sep 2017 10:08:09 -0400	[thread overview]
Message-ID: <20170905140808.GA5970@zipoli.concurrent-rt.com> (raw)

Hi Sasha,
The backport of

   fac8e0f579695a3ecbc4d3cac369139d7f819971
   tunnels: Don't apply GRO to multiple layers of encapsulation

into 4.1 missed a hunk.  The same backport into 3.18 was done
correctly.  This patch introduces the missing hunk into 4.1.
Excepts from some emails:

Joe Korty wrote:
> I am not experiencing any bad symptoms.  I simply noticed
> that the patch introduced a new function, sit_gro_receive,
> without introducing any users, and that same patch in
> linux-4.4.y does have a user.

Jesse gross wrote:
> Thanks for pointing that out. The line you mentioned
> should indeed be there and seems to have been missed in
> the backport.
> 
> The backport was actually done by Sasha, not by me -
> would you mind sending a patch to him or working with him
> to fix it?

Could you review this and run it through your tests and
send it along to Greg if appropriate?

Thanks,
Joe

Signed-off-by: Joe Korty <joe.korty@concurrent-rt.com>

Index: b/net/ipv6/ip6_offload.c
===================================================================
--- a/net/ipv6/ip6_offload.c
+++ b/net/ipv6/ip6_offload.c
@@ -300,7 +300,7 @@ static struct packet_offload ipv6_packet
 	.type = cpu_to_be16(ETH_P_IPV6),
 	.callbacks = {
 		.gso_segment = ipv6_gso_segment,
-		.gro_receive = ipv6_gro_receive,
+		.gro_receive = sit_gro_receive,
 		.gro_complete = ipv6_gro_complete,
 	},
 };

             reply	other threads:[~2017-09-05 14:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-05 14:08 joe.korty [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-08-31 13:58 tunnels: Don't apply GRO to multiple layers of encapsulation joe.korty
2017-09-02  3:40 ` Jesse Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170905140808.GA5970@zipoli.concurrent-rt.com \
    --to=joe.korty@concurrent-rt.com \
    --cc=alexander.levin@verizon.com \
    --cc=jesse@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox