From: Greg KH <gregkh@linuxfoundation.org>
To: Janani Sankara Babu <jananis37@gmail.com>
Cc: devel@driverdev.osuosl.org, goudapatilk@gmail.com,
insafonov@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging:rtl8188eu Fix msleep < 20ms can sleep upto 20ms
Date: Tue, 5 Sep 2017 16:14:32 +0200 [thread overview]
Message-ID: <20170905141432.GB29729@kroah.com> (raw)
In-Reply-To: <1504606001-31970-1-git-send-email-jananis37@gmail.com>
On Tue, Sep 05, 2017 at 03:36:41PM +0530, Janani Sankara Babu wrote:
> This patch solves the following warning shown by checkpatch script
> Warning: msleep < 20ms can sleep for up to 20ms
>
> Signed-off-by: Janani Sankara Babu <jananis37@gmail.com>
> ---
> drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c b/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
> index f86c9ce..78edc15 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
> @@ -436,7 +436,7 @@ s32 LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms)
> DBG_88E("%s: Wait for FW LPS leave more than %u ms!!!\n", __func__, delay_ms);
> break;
> }
> - msleep(1);
> + usleep_range(0, 1000);
How do you know this is a valid range to sleep for?
next prev parent reply other threads:[~2017-09-05 14:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 10:06 [PATCH] staging:rtl8188eu Fix msleep < 20ms can sleep upto 20ms Janani Sankara Babu
2017-09-05 14:14 ` Greg KH [this message]
2017-09-05 14:16 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170905141432.GB29729@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=goudapatilk@gmail.com \
--cc=insafonov@gmail.com \
--cc=jananis37@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox