From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753415AbdIESw4 (ORCPT ); Tue, 5 Sep 2017 14:52:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:33192 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752155AbdIESwz (ORCPT ); Tue, 5 Sep 2017 14:52:55 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C8A821E92 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Tue, 5 Sep 2017 15:52:51 -0300 From: Arnaldo Carvalho de Melo To: Andi Kleen Cc: Andi Kleen , jolsa@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf stat Message-ID: <20170905185251.GL22298@kernel.org> References: <20170831194036.30146-1-andi@firstfloor.org> <20170831194036.30146-7-andi@firstfloor.org> <20170904171128.GB22298@kernel.org> <20170904173725.GU2482@two.firstfloor.org> <20170905180919.GG22298@kernel.org> <20170905181952.GV28715@tassilo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170905181952.GV28715@tassilo.jf.intel.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Sep 05, 2017 at 11:19:52AM -0700, Andi Kleen escreveu: > On Tue, Sep 05, 2017 at 03:09:19PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Mon, Sep 04, 2017 at 10:37:25AM -0700, Andi Kleen escreveu: > > > But you can get it here > > > git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc.git perf/intel-json-metrics-2 > > Ok, so I tried installing the Broadwell ones (one of my test machines) > > and got into: > I would suggest to apply all the patches from the patchkit before you test. > Some of the later ones add/fix stuff needed by some of the metrics. > > > > > [root@jouet ~]# perf stat -M Pipeline flops > > bpf: builtin compilation failed: -95, try external compiler > > ERROR: problems with path cpu/uops_executed.c: No such file or directory > > Cannot set up events {uops_retired.retire_slots,inst_retired.any}:W,{inst_retired.any,cycles}:W,{uops_executed.thread,cpu/uops_executed.core,cmask=1/,uops_executed.cycles_ge_1_uop_exec}:W > > > > Usage: perf stat [] [] > > > > -M, --metrics > > monitor specified metrics or metric groups (separated by ,) > > [root@jouet ~]# perf stat -M Pipeline flops > > > > > > Wasn't this already fixed? > > Yes that was supposed to be fixed with > perf bpf: Tighten detection of BPF events > > perf stat -e cpu/uops_executed.core,cmask=1/ > I'll check. Ok, I couldn't reproduce it anymore, after you check this, please let me know if I should pull that perf/intel-json-metrics-2 branch so that someone wanting to test this can have it all in one place, ok? - Arnaldo