From: Tejun Heo <tj@kernel.org>
To: zijun_hu <zijun_hu@zoho.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
jiangshanlai@gmail.com, linux-kernel@vger.kernel.org,
zijun_hu@htc.com
Subject: Re: [PATCH 1/1] workqueue: use type int instead of bool to index array
Date: Wed, 6 Sep 2017 07:33:20 -0700 [thread overview]
Message-ID: <20170906143320.GK1774378@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <59AF6CB6.4090609@zoho.com>
Hello,
On Wed, Sep 06, 2017 at 11:34:14AM +0800, zijun_hu wrote:
> From: zijun_hu <zijun_hu@htc.com>
>
> type bool is used to index three arrays in alloc_and_link_pwqs()
> it doesn't look like conventional.
>
> it is fixed by using type int to index the relevant arrays.
bool is a uint type which can be either 0 or 1. I don't see what the
benefit of this patch is.q
Thanks.
--
tejun
next prev parent reply other threads:[~2017-09-06 14:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 3:34 [PATCH 1/1] workqueue: use type int instead of bool to index array zijun_hu
2017-09-06 14:33 ` Tejun Heo [this message]
2017-09-06 16:04 ` zijun_hu
2017-09-06 16:40 ` Tejun Heo
2017-09-06 17:07 ` zijun_hu
2017-09-06 17:22 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170906143320.GK1774378@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zijun_hu@htc.com \
--cc=zijun_hu@zoho.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox