From: Greg KH <gregkh@linuxfoundation.org>
To: Srishti Sharma <srishtishar@gmail.com>
Cc: gilad@benyossef.com, devel@driverdev.osuosl.org,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH] Staging: ccree: Prefer using BIT macro.
Date: Thu, 7 Sep 2017 15:53:50 +0200 [thread overview]
Message-ID: <20170907135350.GA27426@kroah.com> (raw)
In-Reply-To: <1504792029-8050-1-git-send-email-srishtishar@gmail.com>
On Thu, Sep 07, 2017 at 07:17:09PM +0530, Srishti Sharma wrote:
> Use BIT(x) instead of (1<<x), reported by checkpatch.pl.
>
> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
> ---
> drivers/staging/ccree/ssi_cipher.h | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/ccree/ssi_cipher.h b/drivers/staging/ccree/ssi_cipher.h
> index 296b375..6fbcf9d 100644
> --- a/drivers/staging/ccree/ssi_cipher.h
> +++ b/drivers/staging/ccree/ssi_cipher.h
> @@ -27,11 +27,11 @@
> #include "ssi_buffer_mgr.h"
>
> /* Crypto cipher flags */
> -#define CC_CRYPTO_CIPHER_KEY_KFDE0 (1 << 0)
> -#define CC_CRYPTO_CIPHER_KEY_KFDE1 (1 << 1)
> -#define CC_CRYPTO_CIPHER_KEY_KFDE2 (1 << 2)
> -#define CC_CRYPTO_CIPHER_KEY_KFDE3 (1 << 3)
> -#define CC_CRYPTO_CIPHER_DU_SIZE_512B (1 << 4)
> +#define CC_CRYPTO_CIPHER_KEY_KFDE0 BIT(0)
> +#define CC_CRYPTO_CIPHER_KEY_KFDE1 BIT(1)
> +#define CC_CRYPTO_CIPHER_KEY_KFDE2 BIT(2)
> +#define CC_CRYPTO_CIPHER_KEY_KFDE3 BIT(3)
> +#define CC_CRYPTO_CIPHER_DU_SIZE_512B BIT(4)
Care to use a <TAB> here as well? I know the original didn't, but the
cleaned up code should.
thanks,
greg k-h
prev parent reply other threads:[~2017-09-07 13:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 13:47 [PATCH] Staging: ccree: Prefer using BIT macro Srishti Sharma
2017-09-07 13:53 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170907135350.GA27426@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gilad@benyossef.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=srishtishar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox