* [PATCH] Staging: ccree: Prefer using BIT macro.
@ 2017-09-07 13:47 Srishti Sharma
2017-09-07 13:53 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Srishti Sharma @ 2017-09-07 13:47 UTC (permalink / raw)
To: gilad
Cc: gregkh, linux-crypto, driverdev-devel, devel, linux-kernel,
outreachy-kernel, Srishti Sharma
Use BIT(x) instead of (1<<x), reported by checkpatch.pl.
Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
---
drivers/staging/ccree/ssi_cipher.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/ccree/ssi_cipher.h b/drivers/staging/ccree/ssi_cipher.h
index 296b375..6fbcf9d 100644
--- a/drivers/staging/ccree/ssi_cipher.h
+++ b/drivers/staging/ccree/ssi_cipher.h
@@ -27,11 +27,11 @@
#include "ssi_buffer_mgr.h"
/* Crypto cipher flags */
-#define CC_CRYPTO_CIPHER_KEY_KFDE0 (1 << 0)
-#define CC_CRYPTO_CIPHER_KEY_KFDE1 (1 << 1)
-#define CC_CRYPTO_CIPHER_KEY_KFDE2 (1 << 2)
-#define CC_CRYPTO_CIPHER_KEY_KFDE3 (1 << 3)
-#define CC_CRYPTO_CIPHER_DU_SIZE_512B (1 << 4)
+#define CC_CRYPTO_CIPHER_KEY_KFDE0 BIT(0)
+#define CC_CRYPTO_CIPHER_KEY_KFDE1 BIT(1)
+#define CC_CRYPTO_CIPHER_KEY_KFDE2 BIT(2)
+#define CC_CRYPTO_CIPHER_KEY_KFDE3 BIT(3)
+#define CC_CRYPTO_CIPHER_DU_SIZE_512B BIT(4)
#define CC_CRYPTO_CIPHER_KEY_KFDE_MASK (CC_CRYPTO_CIPHER_KEY_KFDE0 | CC_CRYPTO_CIPHER_KEY_KFDE1 | CC_CRYPTO_CIPHER_KEY_KFDE2 | CC_CRYPTO_CIPHER_KEY_KFDE3)
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: ccree: Prefer using BIT macro.
2017-09-07 13:47 [PATCH] Staging: ccree: Prefer using BIT macro Srishti Sharma
@ 2017-09-07 13:53 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2017-09-07 13:53 UTC (permalink / raw)
To: Srishti Sharma
Cc: gilad, devel, driverdev-devel, linux-kernel, outreachy-kernel,
linux-crypto
On Thu, Sep 07, 2017 at 07:17:09PM +0530, Srishti Sharma wrote:
> Use BIT(x) instead of (1<<x), reported by checkpatch.pl.
>
> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
> ---
> drivers/staging/ccree/ssi_cipher.h | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/ccree/ssi_cipher.h b/drivers/staging/ccree/ssi_cipher.h
> index 296b375..6fbcf9d 100644
> --- a/drivers/staging/ccree/ssi_cipher.h
> +++ b/drivers/staging/ccree/ssi_cipher.h
> @@ -27,11 +27,11 @@
> #include "ssi_buffer_mgr.h"
>
> /* Crypto cipher flags */
> -#define CC_CRYPTO_CIPHER_KEY_KFDE0 (1 << 0)
> -#define CC_CRYPTO_CIPHER_KEY_KFDE1 (1 << 1)
> -#define CC_CRYPTO_CIPHER_KEY_KFDE2 (1 << 2)
> -#define CC_CRYPTO_CIPHER_KEY_KFDE3 (1 << 3)
> -#define CC_CRYPTO_CIPHER_DU_SIZE_512B (1 << 4)
> +#define CC_CRYPTO_CIPHER_KEY_KFDE0 BIT(0)
> +#define CC_CRYPTO_CIPHER_KEY_KFDE1 BIT(1)
> +#define CC_CRYPTO_CIPHER_KEY_KFDE2 BIT(2)
> +#define CC_CRYPTO_CIPHER_KEY_KFDE3 BIT(3)
> +#define CC_CRYPTO_CIPHER_DU_SIZE_512B BIT(4)
Care to use a <TAB> here as well? I know the original didn't, but the
cleaned up code should.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-07 13:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-07 13:47 [PATCH] Staging: ccree: Prefer using BIT macro Srishti Sharma
2017-09-07 13:53 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox