From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755963AbdIGSsK (ORCPT ); Thu, 7 Sep 2017 14:48:10 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:44704 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755551AbdIGSsI (ORCPT ); Thu, 7 Sep 2017 14:48:08 -0400 Date: Thu, 7 Sep 2017 19:47:45 +0100 From: Roman Gushchin To: Shakeel Butt CC: Johannes Weiner , Linux MM , Michal Hocko , Vladimir Davydov , , , LKML Subject: Re: [PATCH] mm: memcontrol: use per-cpu stocks for socket memory uncharging Message-ID: <20170907184745.GA20598@castle.DHCP.thefacebook.com> References: <20170829100150.4580-1-guro@fb.com> <20170829192621.GA5447@cmpxchg.org> <20170830105524.GA2852@castle.dhcp.TheFacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) X-Originating-IP: [2620:10d:c092:200::1:9067] X-ClientProxiedBy: DB6P18901CA0001.EURP189.PROD.OUTLOOK.COM (2603:10a6:4:16::11) To BL2PR15MB1073.namprd15.prod.outlook.com (2603:10b6:201:17::7) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d537573a-0d4c-4eab-67a3-08d4f620f462 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:BL2PR15MB1073; X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB1073;3:CNs2VKFqafxUJesHlmVuM7x5LIS8Q36WNnI4RydTaljBNNxysrl1a3Ic7HaJcpvrigmPK1q954aWK9OJPoMDdZuOS0sGKPQLQXKVIR3ihTSysOMK/8uyWM1A+ij4mzve20Aa4H3g1y2FTAW2qA+3HXH50PqobHp69yLUXQIVSD41BTETx9AtVroiSbiA0VEifgryz4Lb8UI2GvO44pYzZTMaPGKM9Pzy3xqJ+7F9lrQiP7Y7au8RqEsluVXjf7oS;25:lMFhDp71wrJ52jvOqrcGLGxD1Zz78bxpml30xavWt3MOD8aaZBmueVZAgqtN/paQfcG01w6aqMMOhwR/dIGq/ICSCr9zoLDN7sYg1yrbHyqa4Uh+M2voHOX6/eN0Qui7m5F0zHnMnJX6JMu3Th8Vk5GYDGhiBFt2ZhovqWXvOxMdOhTaHAb1PMw5KFeZ38FwIt1QcY5XbMGOyQCfBYZ8V6V5zgp0xucGRHzX+c0H2ikJoagus0p3KZxs4c6hIf/WMG1w4OFTsGvQRVuOKIXcCAPflEQR1/AbsxPtC1VLM3r4VOAMT1AR+vyPbxHjfhppgJBlT91Mn4JZdmSlgy1zDw==;31:/Tdl2541Do+KfEzhaF65vYbEeZx5kihzfnQqG+0ROj9qp8Cj8BX8QRERh1FBGt3AZ4chu7+B5mmFnaE6Kyo9jCEoj2vzIoigib7XlZ1pqsMFdFScc8K7gkeAyEFPxByUgVgJ88wrGWTPlW+3hDHcTorA+/gHq7JCLaFj2FTpAs+rhWn/kQytJCTO8vi5HCIfVVYWsoRf5EEdMG+AGVjIjHzK9ZoADssR/ja9WTWTJuw= X-MS-TrafficTypeDiagnostic: BL2PR15MB1073: X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB1073;20:UwYwhHZGhAg5Z0GvR91s4K35IkxnZG6wbwOF+OSrbOwcH9ySR7QF6JeaFErK4TMYn1ol2PcjbKyvb+S+v9F3daR4+NCte05nij0ho9c1VLDfK/Z1M9+duF/r81qN6e+Bk6efvsC0YGw4XqQi6A7otgYe8BeU833jpu/QXzLidYYti9b9LD/zvLWvzXjPhmyQlbZNOwqkdGIdfPjFNsrrPcHC2Fxm+28rtd5JFJSsF/tADMSrDMkyi/e9Wkx8bukr8Uasq3e82K+UdGr3hwiKnxSGpMgL05w8rc3dXjXOWYLO+yjgSEcWWXKZrAE+hNrj3DQ4YPqvwmJ2p6arlvHsObJRdIxJ29DbBXD3HE7v0wFyr/xPYmdMcQyO5NxtsC2pGm3GOZ8+Psm/1CbQetQbrA8pGChoXgWR17wj9iumMZR3ofiq0aDm8Z09UPXnH92kWiItEFWdlbyd2MiuSAdft6LyWcbzIJibdSFdWzisBYChoxyTZ3iPCHfLc2l68oBJ;4:/QugJlDJr9gmY4jMoguXfFep9YBK8kXeyzZClorFdEAykxfQOqrI1SOiEgcnodC0REdFb5ccitY3lARyRm2egTDPGq8QYa8gtTYvk1I85qOO6ewYFErjayYtM80rfSFpvGd7QxuUj0NZyamYCXGwP34o5RJPCK+BAZlu+aOS6TrJI2BUmW1SbsnhprCtBT8Usq9VbYFDEGMEwsAl8Xr76n4gfCTSbbuqdBjUNIn8CS7UaTAngHfLrPwzR9kX1rLK X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(100000703101)(100105400095)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123562025)(20161123558100)(20161123564025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BL2PR15MB1073;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BL2PR15MB1073; X-Forefront-PRVS: 04238CD941 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(24454002)(189002)(199003)(6916009)(2906002)(50986999)(305945005)(76176999)(54356999)(7736002)(81166006)(229853002)(8676002)(86362001)(6506006)(6666003)(2950100002)(81156014)(33656002)(8936002)(47776003)(50466002)(5660300001)(101416001)(54906002)(106356001)(68736007)(105586002)(189998001)(55016002)(25786009)(42186005)(9686003)(93886005)(1076002)(6116002)(478600001)(97736004)(23726003)(53936002)(83506001)(110136004)(6246003)(39060400002)(4326008)(4001350100001)(18370500001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:BL2PR15MB1073;H:castle.DHCP.thefacebook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BL2PR15MB1073;23:9AH0gOVj9Ig1jfrGhyngpntE69czR+giQtEjCKJ0k?= =?us-ascii?Q?JBDRt7iEeFCqzRDxo8XU/dBgqY4fibQyCNLdRML9ktrI1Oos71Wbr0pzj+Yh?= =?us-ascii?Q?jEwr6JX831lEOIkoXpOB4zZBioJ+RIA/ETExccdtwCQiuz6U8CK2XWKLVSt/?= =?us-ascii?Q?2KNM+H9Pzl1XyRGuXKwkU1LMJ2IreK9/OMjxM9LrSAVE+wyaJvZeDZzbX/kv?= =?us-ascii?Q?/o3ivu0SvNAh5hORZCSHx+5pCLKa0TN4w48urQMUxSV+n/l5aresa+iv+AcI?= =?us-ascii?Q?Ofo5HT7aZK2flqj9ze7OOyiG0k9bhVSWI6bagwGuZjqi7fm3l1hUaKhsN2z/?= =?us-ascii?Q?bK8PgpIl4x9vp4p9lMkYOZj5GnJH4AyEnGvSZXyv/VR0ybsJdVCzBEwJmtdr?= =?us-ascii?Q?wquqBd3y/gQSCWBB9jDA/q1o+i+8lrKjC7MGS7CzQxpeC8ztJFjB7Ps0S4Xa?= =?us-ascii?Q?cYl5z0okh+xhk2BvOxHM4rCcyJq0IJg7XuO8MNuypAY1oVbBQd0zstPVpN6/?= =?us-ascii?Q?6gG2297nQ63U3p7jmyq/hKJVBthHtlePQfWGdz/HUDkOrHV3a6wdF74u4Laj?= =?us-ascii?Q?F2MfGSMkWteSn9nMcczebwsWgYiDd2JOHyfuJEXjXoCTdgEuyGaaNtwQUPbB?= =?us-ascii?Q?/siBr8cg4P6JPpM+urHYaB3A8vM9KGkdDim/qdiXEZmPIRkt9JHiwQ57NdhP?= =?us-ascii?Q?9IRW2aEpoev7dcOAW3A5t9TTCVmhrgFabXQ4Kc1FOGeEV3jQRZSegfkxRv4I?= =?us-ascii?Q?wVnJhSPsn6tQqVoOOZGk+AP3xXjb3o++xQn8/XAZ4YSS3o7bXNZKVD+fQrc/?= =?us-ascii?Q?3+TIKkBV/Z6W9pLRIxQtTpdgUtfOrgF0dT1jreQb98NO3SHexdHuiRJaRqCR?= =?us-ascii?Q?VWoeQGhx6MEdJUFgy1Z5dCU1Urta00P0Lcb0sFnvWOZRvvmzNHc57Yz40LIA?= =?us-ascii?Q?+ogguWDdimnn1ZTFMoXY67Qf4AwAht6s+9w+JTw1AelLDtbC4vP107pm1mBI?= =?us-ascii?Q?b4tngjQ5SKDBcxN+HbdxwBOfwhB5WdmTn1opZ7r+PueIeK+3VQtzVZkw02ol?= =?us-ascii?Q?SH1kS22k54FDTU2MTtVjxedu+Vy4QbK57IrYbDeip9VlGuvfzzD3jB6ugLP3?= =?us-ascii?Q?0VOYhyGl3QAu6UCpUBa4j7Nmz8eMJGO+HZD1T/zf5t8rzzq/WjzWH5l+bGgW?= =?us-ascii?Q?Xn0HkxD054HnjI=3D?= X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB1073;6:kHOkLtHZoleR3x3xgrAdz+KKauBGW091X42ao9ibGAf4lffoQ6bjrc1d5QZqiFo2q0pp3QyHxcyzG7Thti1zB4NQw1Z2S2V0PeTNsRmbmBz+dEFilo/AYVmE1V6Jb6GroYeGzPsnqhW68kE6lG0pWnIKYYGeSeosz5SDjEFLzPAordv+hUZEPhzgB9PxgzlEQccWAaFLCKfvfy8+vssAD1JDAfxFfFsU62kyf8NUoRnS0XKj1MWL53fQ8g2lvX+G+H/1OnOSNMwmKkMVW9dmqTilnyd1CZROFVBqIyUaA69CYczRfqpX8AyBjh8rpg9tO2eHXGJYqSvQ1ZG7bYbEwg==;5:/wyWh3teWJENY+3b7SOWR/vB1esIBx84Fg7L0ZDaNJWTWNJgP9wi9FPkFl6itOg33xZSj+suxQ3jTa0UPs14TQ6JOwVjsNsBsFoc7jj5oiod98fkEsXnZs3ulQ9wUrWbmDG7nPzyfxJT/V9RSQ9Ing==;24:orAyFd0Ng4MAAOBIEB+HfrKArcp66lY9ldv1+1rPN27jWFLBHAFRLSjIG4lvx5KT298a9CGvN5S+HeIZDVVkRLFr8yseLs1Tt/5nv/7LAX4=;7:n6jhABfKZuxYOOfcJWqCRcJ7DwoHqujTDMwN1/bRazuWWfoApreClYDka66Uhx1N8Y0UjbgVoOa5fk6GDyFptpQpiGkhjUxzQDuiLWrHtrqKzxYHXElm4wD6LqRkEmiRfEdtLKlrQVanWJIt0CLuQleR1k3B+qXQ7kCtn2wyQ/SyT1hByjMZ5cS9aERvn9zrrAoRlPmD9vlayvdNXrubb/mrFBHTMRIB2xpuczQP/uc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB1073;20:/2t7z09QJXCdR8g+JqFyrcnycCN5+v9cPmAnPmSo+l2AjxYQgem2TmTIvi1LY4g7wEDWoX2i4n4RZaAWOK2tM3wcUbR3x94akSwgvrWuNQJCrNQCDksUyXoyTSP1rrkY6D/nQtEjUi/r1vjZGbN59qc2adoyfeUsGrw6mZIfoug= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2017 18:47:55.4464 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR15MB1073 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-09-07_11:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 07, 2017 at 11:44:12AM -0700, Shakeel Butt wrote: > >> As far as other types of pages go: page cache and anon are already > >> batched pretty well, but I think kmem might benefit from this > >> too. Have you considered using the stock in memcg_kmem_uncharge()? > > > > Good idea! > > I'll try to find an appropriate testcase and check if it really > > brings any benefits. If so, I'll master a patch. > > > > Hi Roman, did you get the chance to try this on memcg_kmem_uncharge()? Hi Shakeel! Not yet, I'll try to it asap. Do you have an example when it's costly? Thanks!