public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Cc: Linux Doc Mailing List <linux-doc@vger.kernel.org>,
	Mauro Carvalho Chehab <mchehab@infradead.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] Two cleanups for Sphinx conf.py
Date: Fri, 8 Sep 2017 10:10:26 -0600	[thread overview]
Message-ID: <20170908101026.32969fee@lwn.net> (raw)
In-Reply-To: <cover.1504465478.git.mchehab@s-opensource.com>

On Sun,  3 Sep 2017 16:12:44 -0300
Mauro Carvalho Chehab <mchehab@s-opensource.com> wrote:

> Those patches are just cleanups for Documentation/conf.py. 
> 
> The first one removes a package usage directive for a LateX package
> that it is not used. 
> 
> The second one moves some LaTeX preamble code that it is used only
> on Sphinx 1.4 and 1.5 to a separate if. On Sphinx 1.6, the macros there
> are silently ignored. While the conf.py becomes a little bit more complex,
> it clearly marks the backward-compatible code, with IMHO, it is a
> good idea, specially as some day, we may drop support for older Sphinx
> versions.
> 
> None of those patches are mandatory. Feel free to apply any time you
> want (or discard them, if you don't thing it is worth).

OK, these are applied (and the adjustbox one too).

PDF generation seems to work pretty well at the moment, with one
exception: I don't get a table of contents in any of the files (just a
blank page saying "Contents").  Are you seeing something different?

Thanks,

jon

  parent reply	other threads:[~2017-09-08 16:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-03 19:12 [PATCH 0/2] Two cleanups for Sphinx conf.py Mauro Carvalho Chehab
2017-09-03 19:12 ` [PATCH 1/2] docs-rst: conf.py: remove lscape from LaTeX preamble Mauro Carvalho Chehab
2017-09-03 19:12 ` [PATCH 2/2] docs-rst: conf.py: only setup notice box colors if Sphinx < 1.6 Mauro Carvalho Chehab
2017-09-08 16:10 ` Jonathan Corbet [this message]
2017-09-08 19:02   ` [PATCH 0/2] Two cleanups for Sphinx conf.py Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170908101026.32969fee@lwn.net \
    --to=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=mchehab@s-opensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox