From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753196AbdIHJdX (ORCPT ); Fri, 8 Sep 2017 05:33:23 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:6000 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751365AbdIHJdV (ORCPT ); Fri, 8 Sep 2017 05:33:21 -0400 Date: Fri, 8 Sep 2017 10:32:57 +0100 From: Jonathan Cameron To: Jonathan Cameron CC: Himanshi Jain , , , , , , , , , , Subject: Re: [PATCH] Staging: iio: adc: Added Space around binary op. Message-ID: <20170908103257.00002165@huawei.com> In-Reply-To: References: <20170908044752.GA6199@himanshi-Inspiron-5558> Organization: Huawei X-Mailer: Claws Mail 3.15.0 (GTK+ 2.24.31; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.206.48.115] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090205.59B263DC.000A,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: baec6dda5f4ba42d4436880dff1d48e7 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 8 Sep 2017 07:29:06 +0100 Jonathan Cameron wrote: > On 8 September 2017 05:47:52 BST, Himanshi Jain wrote: > >Added space around(one on each side of) binary > >operator(-) as preferred according to kernel > >coding style. > > > >Signed-off-by: Himanshi Jain > > Take a closer look at that macro. It isn't doing what you think... > To give a hint, changing this breaks userspace. Ok, I'm bored of this particular one coming up. When you have worked out what is going on Himanshi, would you mind putting together a patch adding a comment describing why it is a bad idea to 'fix' this? That would be a very useful patch as far as I'm concerned :) There aren't that many cases of this in IIO so adding a comment on each of them is probably reasonable just to avoid wasting people's time on fixing them! (I think we have had more than 5 such goes this year so far...) Jonathan > > Jonathan > > > >--- > > drivers/staging/iio/adc/ad7192.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >diff --git a/drivers/staging/iio/adc/ad7192.c > >b/drivers/staging/iio/adc/ad7192.c > >index d11c6de..1aee662 100644 > >--- a/drivers/staging/iio/adc/ad7192.c > >+++ b/drivers/staging/iio/adc/ad7192.c > >@@ -341,7 +341,7 @@ static int ad7192_setup(struct ad7192_state *st, > > } > > > > static IIO_DEVICE_ATTR_NAMED(in_v_m_v_scale_available, > >- in_voltage-voltage_scale_available, > >+ in_voltage - voltage_scale_available, > > 0444, ad7192_show_scale_available, NULL, 0); > > > > static IIO_DEVICE_ATTR(in_voltage_scale_available, 0444, >