From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932121AbdIHML2 (ORCPT ); Fri, 8 Sep 2017 08:11:28 -0400 Received: from mga05.intel.com ([192.55.52.43]:50706 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753802AbdIHML1 (ORCPT ); Fri, 8 Sep 2017 08:11:27 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,361,1500966000"; d="scan'208";a="898362547" Date: Fri, 8 Sep 2017 15:11:22 +0300 From: Jarkko Sakkinen To: Alexander Steffen Cc: tpmdd-devel@lists.sourceforge.net, benoit.houyere@st.com, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH RESEND v3 0/2] tpm_tis_spi: Use DMA-safe memory Message-ID: <20170908121122.2frkkcoidoc3u7g2@linux.intel.com> References: <20170831165819.13544-1-Alexander.Steffen@infineon.com> <20170906125458.ueqpmokh7bg64olc@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170906125458.ueqpmokh7bg64olc@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 06, 2017 at 03:54:58PM +0300, Jarkko Sakkinen wrote: > On Thu, Aug 31, 2017 at 06:58:17PM +0200, Alexander Steffen wrote: > > The documentation says that DMA-safe memory is required for SPI transfers. > > The I/O buffers passed in by the caller can be allocated anywhere, > > including on the stack, which is not DMA-safe. So the data needs to be > > copied to separate, DMA-safe buffers. > > > > We did not see any DMA-related issues on our test systems, even without > > DMA-safe buffers. But this might simply be due to the fact that the SPI > > transfer size is rather small, so our systems do not bother to set up DMA > > transfers. Other systems might do so. > > > > v2: > > - Updated commit message with more explanations. > > > > v3: > > - Split into two patches, one for making the buffers DMA-safe and another > > for using only a single buffer. > > > > Alexander Steffen (2): > > tpm_tis_spi: Use DMA-safe memory for SPI transfers > > tpm_tis_spi: Use a single buffer for SPI transfers > > > > drivers/char/tpm/tpm_tis_spi.c | 32 ++++++++++++++++++-------------- > > 1 file changed, 18 insertions(+), 14 deletions(-) > > > > -- > > 2.7.4 > > > > Applied to my bleeding edge master brach for more convenient testing. > Have not yet applied to my next branch. > > /Jarkko Tested-by: Jarkko Sakkinen My XP13 happened to have suitable TPM. /Jarkko