From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932097AbdIHMfQ (ORCPT ); Fri, 8 Sep 2017 08:35:16 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:40442 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754713AbdIHMfO (ORCPT ); Fri, 8 Sep 2017 08:35:14 -0400 Date: Fri, 8 Sep 2017 14:35:13 +0200 From: Pavel Machek To: Arnd Bergmann Cc: Mauro Carvalho Chehab , Richard Purdie , Jacek Anaszewski , Sakari Ailus , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: leds: as3645a: add V4L2_FLASH_LED_CLASS depdendency Message-ID: <20170908123513.GM18365@amd> References: <20170905071345.3807685-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3FyYKcuUbgqNYeqV" Content-Disposition: inline In-Reply-To: <20170905071345.3807685-1-arnd@arndb.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --3FyYKcuUbgqNYeqV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue 2017-09-05 09:13:20, Arnd Bergmann wrote: > We get a link error when V4L2_FLASH_LED_CLASS=3Dm and AS3645A is built-in: >=20 > drivers/leds/leds-as3645a.o: In function `as3645a_v4l2_setup': > leds-as3645a.c:(.text+0x258): undefined reference to `v4l2_flash_init' > leds-as3645a.c:(.text+0x284): undefined reference to `v4l2_flash_indicato= r_init' > leds-as3645a.c:(.text+0x2a4): undefined reference to `v4l2_flash_release' > drivers/leds/leds-as3645a.o: In function `as3645a_remove': > leds-as3645a.c:(.text+0x784): undefined reference to `v4l2_flash_release' >=20 > This adds the same Kconfig dependency that the other V4L2 flash > drivers in drivers/leds use, to avoid that broken configuration. >=20 > Fixes: a56ba8fbcb55 ("media: leds: as3645a: Add LED flash class driver") > Signed-off-by: Arnd Bergmann Acked-by: Pavel Machek --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --3FyYKcuUbgqNYeqV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlmyjoEACgkQMOfwapXb+vIb2ACfYo10uOC1BPbHjDgt5+efk/5D thcAn27J8L9HwfrGZ+46Aqxh6aYIq/ei =D8rt -----END PGP SIGNATURE----- --3FyYKcuUbgqNYeqV--