From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756083AbdIHObw (ORCPT ); Fri, 8 Sep 2017 10:31:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:40912 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754879AbdIHObu (ORCPT ); Fri, 8 Sep 2017 10:31:50 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E8C322B2D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Fri, 8 Sep 2017 11:31:48 -0300 From: Arnaldo Carvalho de Melo To: Taeung Song Cc: linux-kernel@vger.kernel.org, taeung@kosslab.kr, Jiri Olsa , Namhyung Kim Subject: Re: [PATCH v5 1/3] perf config: Check not only section->from_system_config but also item's Message-ID: <20170908143148.GH11725@kernel.org> References: <1504754325-9724-1-git-send-email-treeze.taeung@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504754325-9724-1-git-send-email-treeze.taeung@gmail.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Sep 07, 2017 at 12:18:45PM +0900, Taeung Song escreveu: > Currently only section->from_system_config is being checked multiple times. > items->from_system_config should be also checked, so fix it. Reworded the cset log as: perf config: Check not only section->from_system_config but also item's Currently section->from_system_config is being checked multiple times. item->from_system_config should be checked instead, when iterating thru the items in a section. Fix it. applied. - Arnaldo > Cc: Jiri Olsa > Cc: Namhyung Kim > Signed-off-by: Taeung Song > --- > tools/perf/builtin-config.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c > index 3ddcc6e..a1d82e3 100644 > --- a/tools/perf/builtin-config.c > +++ b/tools/perf/builtin-config.c > @@ -59,7 +59,7 @@ static int set_config(struct perf_config_set *set, const char *file_name, > fprintf(fp, "[%s]\n", section->name); > > perf_config_items__for_each_entry(§ion->items, item) { > - if (!use_system_config && section->from_system_config) > + if (!use_system_config && item->from_system_config) > continue; > if (item->value) > fprintf(fp, "\t%s = %s\n", > -- > 2.7.4