* [PATCH v5 1/3] perf config: Check not only section->from_system_config but also item's
@ 2017-09-07 3:18 Taeung Song
2017-09-08 14:31 ` Arnaldo Carvalho de Melo
2017-09-13 7:45 ` [tip:perf/urgent] " tip-bot for Taeung Song
0 siblings, 2 replies; 3+ messages in thread
From: Taeung Song @ 2017-09-07 3:18 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo; +Cc: linux-kernel, taeung, Jiri Olsa, Namhyung Kim
Currently only section->from_system_config is being checked multiple times.
items->from_system_config should be also checked, so fix it.
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
---
tools/perf/builtin-config.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c
index 3ddcc6e..a1d82e3 100644
--- a/tools/perf/builtin-config.c
+++ b/tools/perf/builtin-config.c
@@ -59,7 +59,7 @@ static int set_config(struct perf_config_set *set, const char *file_name,
fprintf(fp, "[%s]\n", section->name);
perf_config_items__for_each_entry(§ion->items, item) {
- if (!use_system_config && section->from_system_config)
+ if (!use_system_config && item->from_system_config)
continue;
if (item->value)
fprintf(fp, "\t%s = %s\n",
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v5 1/3] perf config: Check not only section->from_system_config but also item's
2017-09-07 3:18 [PATCH v5 1/3] perf config: Check not only section->from_system_config but also item's Taeung Song
@ 2017-09-08 14:31 ` Arnaldo Carvalho de Melo
2017-09-13 7:45 ` [tip:perf/urgent] " tip-bot for Taeung Song
1 sibling, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2017-09-08 14:31 UTC (permalink / raw)
To: Taeung Song; +Cc: linux-kernel, taeung, Jiri Olsa, Namhyung Kim
Em Thu, Sep 07, 2017 at 12:18:45PM +0900, Taeung Song escreveu:
> Currently only section->from_system_config is being checked multiple times.
> items->from_system_config should be also checked, so fix it.
Reworded the cset log as:
perf config: Check not only section->from_system_config but also item's
Currently section->from_system_config is being checked multiple times.
item->from_system_config should be checked instead, when iterating thru
the items in a section. Fix it.
applied.
- Arnaldo
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
> ---
> tools/perf/builtin-config.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c
> index 3ddcc6e..a1d82e3 100644
> --- a/tools/perf/builtin-config.c
> +++ b/tools/perf/builtin-config.c
> @@ -59,7 +59,7 @@ static int set_config(struct perf_config_set *set, const char *file_name,
> fprintf(fp, "[%s]\n", section->name);
>
> perf_config_items__for_each_entry(§ion->items, item) {
> - if (!use_system_config && section->from_system_config)
> + if (!use_system_config && item->from_system_config)
> continue;
> if (item->value)
> fprintf(fp, "\t%s = %s\n",
> --
> 2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread* [tip:perf/urgent] perf config: Check not only section->from_system_config but also item's
2017-09-07 3:18 [PATCH v5 1/3] perf config: Check not only section->from_system_config but also item's Taeung Song
2017-09-08 14:31 ` Arnaldo Carvalho de Melo
@ 2017-09-13 7:45 ` tip-bot for Taeung Song
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Taeung Song @ 2017-09-13 7:45 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, mingo, acme, jolsa, hpa, namhyung, treeze.taeung,
tglx
Commit-ID: cba225d6eeaf00bd8181a851fbaa7b8716337e0b
Gitweb: http://git.kernel.org/tip/cba225d6eeaf00bd8181a851fbaa7b8716337e0b
Author: Taeung Song <treeze.taeung@gmail.com>
AuthorDate: Thu, 7 Sep 2017 12:18:45 +0900
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 12 Sep 2017 12:35:11 -0300
perf config: Check not only section->from_system_config but also item's
Currently section->from_system_config is being checked multiple times.
item->from_system_config should be checked instead, when iterating thru
the items in a section. Fix it.
Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/r/1504754325-9724-1-git-send-email-treeze.taeung@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-config.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c
index 3ddcc6e..a1d82e3 100644
--- a/tools/perf/builtin-config.c
+++ b/tools/perf/builtin-config.c
@@ -59,7 +59,7 @@ static int set_config(struct perf_config_set *set, const char *file_name,
fprintf(fp, "[%s]\n", section->name);
perf_config_items__for_each_entry(§ion->items, item) {
- if (!use_system_config && section->from_system_config)
+ if (!use_system_config && item->from_system_config)
continue;
if (item->value)
fprintf(fp, "\t%s = %s\n",
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-13 7:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-07 3:18 [PATCH v5 1/3] perf config: Check not only section->from_system_config but also item's Taeung Song
2017-09-08 14:31 ` Arnaldo Carvalho de Melo
2017-09-13 7:45 ` [tip:perf/urgent] " tip-bot for Taeung Song
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox