From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755941AbdIHOeA (ORCPT ); Fri, 8 Sep 2017 10:34:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:41022 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754978AbdIHOd7 (ORCPT ); Fri, 8 Sep 2017 10:33:59 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95FC122B43 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Fri, 8 Sep 2017 11:33:56 -0300 From: Arnaldo Carvalho de Melo To: Taeung Song Cc: linux-kernel@vger.kernel.org, taeung@kosslab.kr, Jiri Olsa , Namhyung Kim Subject: Re: [PATCH v5 2/3] perf config: Once write a config file in the end, not a repeat Message-ID: <20170908143356.GA10112@kernel.org> References: <1504754331-9776-1-git-send-email-treeze.taeung@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504754331-9776-1-git-send-email-treeze.taeung@gmail.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Sep 07, 2017 at 12:18:51PM +0900, Taeung Song escreveu: > Currently set_config() can be repeatedly called for each > input config on the below case: > > $ perf config kmem.default=slab report.children=false ... > > But it's a waste, so only once write a config file > gathering all given config key=value pairs Thanks, applied. - Arnaldo > Cc: Jiri Olsa > Cc: Namhyung Kim > Signed-off-by: Taeung Song > --- > tools/perf/builtin-config.c | 22 ++++++++++++++++------ > 1 file changed, 16 insertions(+), 6 deletions(-) > > diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c > index a1d82e3..b89417d 100644 > --- a/tools/perf/builtin-config.c > +++ b/tools/perf/builtin-config.c > @@ -34,8 +34,7 @@ static struct option config_options[] = { > OPT_END() > }; > > -static int set_config(struct perf_config_set *set, const char *file_name, > - const char *var, const char *value) > +static int set_config(struct perf_config_set *set, const char *file_name) > { > struct perf_config_section *section = NULL; > struct perf_config_item *item = NULL; > @@ -49,7 +48,6 @@ static int set_config(struct perf_config_set *set, const char *file_name, > if (!fp) > return -1; > > - perf_config_set__collect(set, file_name, var, value); > fprintf(fp, "%s\n", first_line); > > /* overwrite configvariables */ > @@ -161,6 +159,7 @@ int cmd_config(int argc, const char **argv) > struct perf_config_set *set; > char *user_config = mkpath("%s/.perfconfig", getenv("HOME")); > const char *config_filename; > + bool changed = false; > > argc = parse_options(argc, argv, config_options, config_usage, > PARSE_OPT_STOP_AT_NON_OPTION); > @@ -231,15 +230,26 @@ int cmd_config(int argc, const char **argv) > goto out_err; > } > } else { > - if (set_config(set, config_filename, var, value) < 0) { > - pr_err("Failed to set '%s=%s' on %s\n", > - var, value, config_filename); > + if (perf_config_set__collect(set, config_filename, > + var, value) < 0) { > + pr_err("Failed to add '%s=%s'\n", > + var, value); > free(arg); > goto out_err; > } > + changed = true; > } > free(arg); > } > + > + if (!changed) > + break; > + > + if (set_config(set, config_filename) < 0) { > + pr_err("Failed to set the configs on %s\n", > + config_filename); > + goto out_err; > + } > } > > ret = 0; > -- > 2.7.4