Re: [PATCH v1 03/10] clk: at91: pmc: Support backup for programmable clocks

Alexandre Belloni
2017-09-13T17:03:28Z

On 13/09/2017 at 14:29:35 +0200, Nicolas Ferre wrote:
> On 08/09/2017 at 17:35, Romain Izard wrote:
> > From: Romain Izard <romain.izard@mobile-devices.fr>
> >
> > Save and restore the System Clock and Programmable Clock register for
> > the backup use case.
>
> "System Clock" seems to be handled in another patch.
>
> > Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
> > ---
> > drivers/clk/at91/pmc.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c
> > index 07dc2861ad3f..5421b03553ec 100644
> > --- a/drivers/clk/at91/pmc.c
> > +++ b/drivers/clk/at91/pmc.c
> > @@ -66,6 +66,7 @@ static struct
> > u32 pcr[PMC_MAX_IDS];
> > u32 audio_pll0;
> > u32 audio_pll1;
> > + u32 pckr[3];
>
> Some products have different numbers of PCK (only 2 on at91sam9x5 for
> instance)...
>

My opinion is that it will be time to change that when multiple SoCs
will need to save their registers.

--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering