From: Greg KH <gregkh@linuxfoundation.org>
To: Pintu Kumar <pintu_agarwal@yahoo.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
riandrews@android.com, arve@android.com, sumit.semwal@linaro.org,
labbott@redhat.com, pintu.k@outlook.com, pintu.ping@gmail.com
Subject: Re: [PATCH 1/1] [staging]: android:ion: replace BUG with WARN_ON
Date: Sat, 9 Sep 2017 16:17:26 +0200 [thread overview]
Message-ID: <20170909141726.GA18801@kroah.com> (raw)
In-Reply-To: <1504963782-2052-1-git-send-email-pintu_agarwal@yahoo.com>
On Sat, Sep 09, 2017 at 06:59:42PM +0530, Pintu Kumar wrote:
> This patch is the fix for the below checkpatch issue:
> CHECK: Avoid crashing the kernel - try using WARN_ON &
> recovery code rather than BUG() or BUG_ON()
> + BUG();
>
> Ideally this condition should never occur. But even if occurs
> there is no point in crashing the whole kernel.
> Just a warning should be enough to find the issue.
Nope, see the archives for when this has been rejected in the past.
You can't just trivially replace BUG with WARN, otherwise it would have
been done already :)
sorry,
greg k-h
parent reply other threads:[~2017-09-09 14:17 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1504963782-2052-1-git-send-email-pintu_agarwal@yahoo.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170909141726.GA18801@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arve@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pintu.k@outlook.com \
--cc=pintu.ping@gmail.com \
--cc=pintu_agarwal@yahoo.com \
--cc=riandrews@android.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox