* Re: [PATCH 1/1] [staging]: android:ion: replace BUG with WARN_ON
[not found] <1504963782-2052-1-git-send-email-pintu_agarwal@yahoo.com>
@ 2017-09-09 14:17 ` Greg KH
0 siblings, 0 replies; only message in thread
From: Greg KH @ 2017-09-09 14:17 UTC (permalink / raw)
To: Pintu Kumar
Cc: linux-kernel, devel, riandrews, arve, sumit.semwal, labbott,
pintu.k, pintu.ping
On Sat, Sep 09, 2017 at 06:59:42PM +0530, Pintu Kumar wrote:
> This patch is the fix for the below checkpatch issue:
> CHECK: Avoid crashing the kernel - try using WARN_ON &
> recovery code rather than BUG() or BUG_ON()
> + BUG();
>
> Ideally this condition should never occur. But even if occurs
> there is no point in crashing the whole kernel.
> Just a warning should be enough to find the issue.
Nope, see the archives for when this has been rejected in the past.
You can't just trivially replace BUG with WARN, otherwise it would have
been done already :)
sorry,
greg k-h
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-09-09 14:17 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1504963782-2052-1-git-send-email-pintu_agarwal@yahoo.com>
2017-09-09 14:17 ` [PATCH 1/1] [staging]: android:ion: replace BUG with WARN_ON Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox