From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757525AbdIIOR3 (ORCPT ); Sat, 9 Sep 2017 10:17:29 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:50160 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753683AbdIIOR2 (ORCPT ); Sat, 9 Sep 2017 10:17:28 -0400 Date: Sat, 9 Sep 2017 16:17:26 +0200 From: Greg KH To: Pintu Kumar Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, riandrews@android.com, arve@android.com, sumit.semwal@linaro.org, labbott@redhat.com, pintu.k@outlook.com, pintu.ping@gmail.com Subject: Re: [PATCH 1/1] [staging]: android:ion: replace BUG with WARN_ON Message-ID: <20170909141726.GA18801@kroah.com> References: <1504963782-2052-1-git-send-email-pintu_agarwal@yahoo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504963782-2052-1-git-send-email-pintu_agarwal@yahoo.com> User-Agent: Mutt/1.9.0 (2017-09-02) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 09, 2017 at 06:59:42PM +0530, Pintu Kumar wrote: > This patch is the fix for the below checkpatch issue: > CHECK: Avoid crashing the kernel - try using WARN_ON & > recovery code rather than BUG() or BUG_ON() > + BUG(); > > Ideally this condition should never occur. But even if occurs > there is no point in crashing the whole kernel. > Just a warning should be enough to find the issue. Nope, see the archives for when this has been rejected in the past. You can't just trivially replace BUG with WARN, otherwise it would have been done already :) sorry, greg k-h