From: Steven Rostedt <rostedt@goodmis.org>
To: Joel Fernandes <joelaf@google.com>
Cc: linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
kernel-team@android.com, Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH RFC v4 1/3] tracing/irqsoff: Prepare to add preempt and irq trace events
Date: Sun, 10 Sep 2017 05:06:22 -0400 [thread overview]
Message-ID: <20170910050622.60e5c96d@vmware.local.home> (raw)
In-Reply-To: <20170907001752.27015-2-joelaf@google.com>
On Wed, 6 Sep 2017 17:17:50 -0700
Joel Fernandes <joelaf@google.com> wrote:
> +#else /* IRQSOFF_TRACER || PREEMPTOFF_TRACER */
> +
> +#define start_critical_timings_tracer() do { } while (0)
> +#define stop_critical_timings_tracer() do { } while (0)
> +
> +#endif
> +
> +#ifndef CONFIG_IRQSOFF_TRACER
> +#define tracer_hardirqs_on() do { } while (0)
> +#define tracer_hardirqs_off() do { } while (0)
> +#define tracer_hardirqs_on_caller(x) do { } while (0)
> +#define tracer_hardirqs_off_caller(x) do { } while (0)
> +#endif
> +
> +#ifndef CONFIG_PREEMPT_TRACER
> +#define tracer_preempt_on(x, y) do { } while (0)
> +#define tracer_preempt_off(x, y) do { } while (0)
> +#endif
Is there a reason the above is #define and not static inline? The
preferred method is static inline as that allows the compiler to check
types. #define is used if one of the parameters has a struct or
something that is not defined.
-- Steve
next prev parent reply other threads:[~2017-09-10 9:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 0:17 [PATCH RFC v4 0/3] tracing: Add trace events for preemption and irq disable/enable Joel Fernandes
2017-09-07 0:17 ` [PATCH RFC v4 1/3] tracing/irqsoff: Prepare to add preempt and irq trace events Joel Fernandes
2017-09-10 9:06 ` Steven Rostedt [this message]
2017-09-10 22:21 ` Joel Fernandes
2017-09-07 0:17 ` [PATCH RFC v4 2/3] tracing: Add support for preempt and irq enable/disable events Joel Fernandes
2017-09-07 0:17 ` [PATCH RFC v4 3/3] ftrace: Use correct config option for preemption debug Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170910050622.60e5c96d@vmware.local.home \
--to=rostedt@goodmis.org \
--cc=joelaf@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox