From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Jassi Brar <jaswinder.singh@linaro.org>,
Keiji Hayashibara <hayashibara.keiji@socionext.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
Carlo Caione <carlo@endlessm.com>,
Michael Grzeschik <m.grzeschik@pengutronix.de>
Subject: Re: Questions about NVMEM
Date: Mon, 11 Sep 2017 04:24:21 -0700 [thread overview]
Message-ID: <20170911112421.GA32265@kroah.com> (raw)
In-Reply-To: <CAK7LNAQvjGfY1o-4+DoE-TANYS_YQ2RhattSL2Q9o1g+AE0GDA@mail.gmail.com>
On Mon, Sep 11, 2017 at 07:33:20PM +0900, Masahiro Yamada wrote:
> >> (Q3) The style of drivers/nvmem/Makefile
> >>
> >> This Makefile looks ugly to me.
> >> All nvmem drivers are just single file modules.
> >> Why are they renamed when modules are created?
> >>
> >> For the name-space reason for modules,
> >> prefix "nvmem-" makes sense to me.
> >>
> >> It is true that adding "nvmem-" prefix is redundant while
> >> they are located in drivers/nvmem/ directory,
> >> but renaming in the Makefile is even more annoying to me.
> >> Having said that, we may not want to churn this.
> >
> > This is mainly done for consistent module naming.
> > I prefer to have nvmem- prefix for nvmem modules.
> >
>
> I 100% agree that all nvmem modules should have "nvmem-" prefix
> consistently.
>
> My question was, why .c files do not have the same file name as
> the module name?
>
> The more straight-forward way would be:
> drivers/nvmem/nvmem_core.c
> drivers/nvmem/nvmem-bcm-ocotp.c
> drivers/nvmem/nvmem-imx-iim.c
> etc.
No, the way the current code is, is just fine, please leave it alone, it
is the style that other subsystems are moving to as well.
thanks,
greg k-h
next prev parent reply other threads:[~2017-09-11 11:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 4:44 Questions about NVMEM Masahiro Yamada
2017-09-11 9:38 ` Srinivas Kandagatla
2017-09-11 10:33 ` Masahiro Yamada
2017-09-11 11:13 ` Srinivas Kandagatla
2017-09-11 12:40 ` Masahiro Yamada
2017-09-11 12:43 ` Srinivas Kandagatla
2017-09-11 11:24 ` Greg Kroah-Hartman [this message]
2017-09-11 12:41 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170911112421.GA32265@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andrew-ct.chen@mediatek.com \
--cc=carlo@endlessm.com \
--cc=hayashibara.keiji@socionext.com \
--cc=jaswinder.singh@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
--cc=mhiramat@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox