From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751629AbdIKL1h (ORCPT <rfc822;w@1wt.eu>);
        Mon, 11 Sep 2017 07:27:37 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:36658 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751013AbdIKL1g (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 11 Sep 2017 07:27:36 -0400
Date: Mon, 11 Sep 2017 04:24:21 -0700
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Jassi Brar <jaswinder.singh@linaro.org>,
        Keiji Hayashibara <hayashibara.keiji@socionext.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
        Carlo Caione <carlo@endlessm.com>,
        Michael Grzeschik <m.grzeschik@pengutronix.de>
Subject: Re: Questions about NVMEM
Message-ID: <20170911112421.GA32265@kroah.com>
References: <CAK7LNATjnDyRjSFjua6D5YR2h9M_Kf58Bd0=qFcOt8q_Uw4mkg@mail.gmail.com>
 <30c449c1-6109-fc32-62c5-f67c0e85274e@linaro.org>
 <CAK7LNAQvjGfY1o-4+DoE-TANYS_YQ2RhattSL2Q9o1g+AE0GDA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAK7LNAQvjGfY1o-4+DoE-TANYS_YQ2RhattSL2Q9o1g+AE0GDA@mail.gmail.com>
User-Agent: Mutt/1.9.0 (2017-09-02)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Sep 11, 2017 at 07:33:20PM +0900, Masahiro Yamada wrote:
> >> (Q3) The style of  drivers/nvmem/Makefile
> >>
> >> This Makefile looks ugly to me.
> >> All nvmem drivers are just single file modules.
> >> Why are they renamed when modules are created?
> >>
> >> For the name-space reason for modules,
> >> prefix "nvmem-" makes sense to me.
> >>
> >> It is true that adding "nvmem-" prefix is redundant while
> >> they are located in drivers/nvmem/ directory,
> >> but renaming in the Makefile is even more annoying to me.
> >> Having said that, we may not want to churn this.
> >
> > This is mainly done for consistent module naming.
> > I prefer to have nvmem- prefix for nvmem modules.
> >
> 
> I 100% agree that all nvmem modules should have "nvmem-" prefix
> consistently.
> 
> My question was, why .c files do not have the same file name as
> the module name?
> 
> The more straight-forward way would be:
> drivers/nvmem/nvmem_core.c
> drivers/nvmem/nvmem-bcm-ocotp.c
> drivers/nvmem/nvmem-imx-iim.c
> etc.

No, the way the current code is, is just fine, please leave it alone, it
is the style that other subsystems are moving to as well.

thanks,

greg k-h