Re: Add TI ICDI as a simple usb serial device

[Greg KH <gregkh@linuxfoundation.org>]

On Mon, Sep 11, 2017 at 12:22:57PM +0000, Dashi DS1 Cao wrote:
> Sorry! Should have submitted the patch inline:
> 
> ---
>  drivers/usb/serial/usb-serial-simple.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/serial/usb-serial-simple.c b/drivers/usb/serial/usb-serial-simple.c
> index e98b6e5..7727eab 100644
> --- a/drivers/usb/serial/usb-serial-simple.c
> +++ b/drivers/usb/serial/usb-serial-simple.c
> @@ -32,7 +32,7 @@ static struct usb_serial_driver vendor##_device = {		\
>  	},							\
>  	.id_table =		vendor##_id_table,		\
>  	.num_ports =		nport,				\
> -};
> +}
>  
>  #define DEVICE(vendor, IDS)	DEVICE_N(vendor, IDS, 1)
>  
> @@ -58,6 +58,10 @@ DEVICE(funsoft, FUNSOFT_IDS);
>  	{ USB_DEVICE(0x8087, 0x0801) }
>  DEVICE(flashloader, FLASHLOADER_IDS);
>  
> +#define ICDI_IDS()		\
> +	{ USB_DEVICE_INTERFACE_CLASS(0x1cbe, 0x00fd, USB_CLASS_VENDOR_SPEC) }
> +DEVICE(icdi, ICDI_IDS);
> +
>  /* Google Serial USB SubClass */
>  #define GOOGLE_IDS()						\
>  	{ USB_VENDOR_AND_INTERFACE_INFO(0x18d1,			\
> @@ -114,6 +118,7 @@ static struct usb_serial_driver * const serial_drivers[] = {
>  	&hp4x_device,
>  	&suunto_device,
>  	&siemens_mpi_device,
> +	&icdi_device,
>  	NULL
>  };
>  
> @@ -129,6 +134,7 @@ static const struct usb_device_id id_table[] = {
>  	HP4X_IDS(),
>  	SUUNTO_IDS(),
>  	SIEMENS_IDS(),
> +	ICDI_IDS(),
>  	{ },
>  };
>  MODULE_DEVICE_TABLE(usb, id_table);
> -- 
> 2.1.4
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch was attached, please place it inline so that it can be
  applied directly from the email message itself.

- Your patch does not have a Signed-off-by: line.  Please read the
  kernel file, Documentation/SubmittingPatches and resend it after
  adding that line.  Note, the line needs to be in the body of the
  email, before the patch, not at the bottom of the patch or in the
  email signature.

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what is needed in order to
  properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what a proper Subject: line should
  look like.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot