From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Amit Pundir <amit.pundir@linaro.org>
Cc: "Todd Kjos" <tkjos@google.com>, "Todd Kjos" <tkjos@android.com>,
"Arve Hjønnevåg" <arve@android.com>,
"open list:ANDROID DRIVERS" <devel@driverdev.osuosl.org>,
lkml <linux-kernel@vger.kernel.org>,
"Martijn Coenen" <maco@google.com>,
"Xu Yiping" <xuyiping@hisilicon.com>,
gengyanping@hisilicon.com, shiwanglai@hisilicon.com,
"John Stultz" <john.stultz@linaro.org>
Subject: Re: [PATCH] binder: fix memory corruption in binder_transaction binder
Date: Mon, 11 Sep 2017 10:24:49 -0700 [thread overview]
Message-ID: <20170911172449.GB21108@kroah.com> (raw)
In-Reply-To: <CAMi1Hd3qrjryXZCCGbET20fJ+0m8C5ZxoghnJdOP225L82wpdg@mail.gmail.com>
On Mon, Sep 11, 2017 at 10:25:14PM +0530, Amit Pundir wrote:
> Hi Todd,
>
> On 11 September 2017 at 21:10, Todd Kjos <tkjos@google.com> wrote:
> > (resend in plain-text mode -- sorry about that)
> >
> > Amit,
> >
> > Are you sure this patch is the culprit? That is pretty surprising
> > since this change can only be hit in a uncommon case (the target node
> > is valid when we start creating the transaction, but dead when we
> > check right before sending it) so it is unlikely to be hit during a
> > normal boot. It also fixes a corruption -- so if you were actually
> > hitting the case, it would likely have caused issues before and not
> > now. Take a look at it and see if you think it is really possible.
> >
> > I just booted hikey to Android with this patch 10 times in a row with
> > no issues (used hikey-linaro 4.9 kernel which has this patch).
>
> Sorry for not being clear enough in the bug report. android-4.9 is
> fine, I see this issue on linux mainline tree with this patch.
What exact kernel release? A number of binder fixes have recently
landed in the stable trees, and in Linus's tree.
thanks,
greg k-h
next prev parent reply other threads:[~2017-09-11 17:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 17:21 [PATCH] binder: fix memory corruption in binder_transaction binder Todd Kjos
2017-09-11 12:18 ` Amit Pundir
[not found] ` <CAHRSSEwVSHSoYJc8JEaAkNwG+v5Fgaq4sO7GZ7otHzyv9m+qFg@mail.gmail.com>
2017-09-11 15:40 ` Todd Kjos
2017-09-11 16:55 ` Amit Pundir
2017-09-11 17:24 ` Greg Kroah-Hartman [this message]
2017-09-11 19:59 ` Todd Kjos
2017-09-12 8:20 ` Martijn Coenen
2017-10-03 8:45 ` Amit Pundir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170911172449.GB21108@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=amit.pundir@linaro.org \
--cc=arve@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=gengyanping@hisilicon.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@google.com \
--cc=shiwanglai@hisilicon.com \
--cc=tkjos@android.com \
--cc=tkjos@google.com \
--cc=xuyiping@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox