From: Guenter Roeck <linux@roeck-us.net>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Badhri Jagan Sridharan <badhri@google.com>,
Yueyao Zhu <yueyao@google.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH 1/5] staging: typec: tcpm: Drop commented out code
Date: Mon, 11 Sep 2017 12:56:44 -0700 [thread overview]
Message-ID: <20170911195644.GA2580@roeck-us.net> (raw)
In-Reply-To: <20170911182601.GA23199@kroah.com>
On Mon, Sep 11, 2017 at 11:26:01AM -0700, Greg Kroah-Hartman wrote:
> On Mon, Sep 11, 2017 at 10:37:11AM -0700, Guenter Roeck wrote:
> > On Mon, Sep 11, 2017 at 09:23:34AM -0700, Greg Kroah-Hartman wrote:
> > > On Sun, Sep 10, 2017 at 01:37:01PM -0700, Guenter Roeck wrote:
> > > > Commented out code can be added as needed. Drop it.
> > > > Also drop TODO and an obsolete XXX comment.
> > > >
> > > > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > > > ---
> > > > drivers/staging/typec/tcpm.c | 37 +------------------------------------
> > > > 1 file changed, 1 insertion(+), 36 deletions(-)
> > >
> > > Thans for the series, I'll queue it up once 4.14-rc1 is out and make a
> > > branch that can get pulled into both the staging and usb trees, so that
> > > future work on this can all happen through the usb tree.
> > >
> > Should I resend to add the '/**' in patch 3, or can you take care of it ?
>
> A resend, with -M format, would always be appreciated :)
>
I did that, as v2, but it does not include the comment change in patch 3.
I'll send v3 tonight.
Guenter
prev parent reply other threads:[~2017-09-11 19:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-10 20:37 [PATCH 1/5] staging: typec: tcpm: Drop commented out code Guenter Roeck
2017-09-10 20:37 ` [PATCH 2/5] staging: typec: tcpm: Document data structures Guenter Roeck
2017-09-10 20:37 ` [PATCH 3/5] staging: typec: pd: Document struct pd_message Guenter Roeck
2017-09-11 10:09 ` Sergei Shtylyov
2017-09-10 20:37 ` [PATCH 4/5] typec: tcpm: Move out of staging Guenter Roeck
2017-09-10 20:46 ` Joe Perches
2017-09-10 21:18 ` Guenter Roeck
2017-09-10 20:37 ` [PATCH 5/5] usb: typec: fusb302: " Guenter Roeck
2017-09-11 16:23 ` [PATCH 1/5] staging: typec: tcpm: Drop commented out code Greg Kroah-Hartman
2017-09-11 17:37 ` Guenter Roeck
2017-09-11 18:26 ` Greg Kroah-Hartman
2017-09-11 19:56 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170911195644.GA2580@roeck-us.net \
--to=linux@roeck-us.net \
--cc=badhri@google.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=yueyao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox