From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751412AbdIKT4t (ORCPT ); Mon, 11 Sep 2017 15:56:49 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:35964 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751031AbdIKT4r (ORCPT ); Mon, 11 Sep 2017 15:56:47 -0400 X-Google-Smtp-Source: ADKCNb5JFpyBtXiOc9Ls88Ym7Duc9rajnLhYI5zGaVvO21XGtTUkOjxUY1gq4GP1etY7zhoqL+wvwQ== Date: Mon, 11 Sep 2017 12:56:44 -0700 From: Guenter Roeck To: Greg Kroah-Hartman Cc: devel@driverdev.osuosl.org, Heikki Krogerus , Badhri Jagan Sridharan , Yueyao Zhu , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Hans de Goede Subject: Re: [PATCH 1/5] staging: typec: tcpm: Drop commented out code Message-ID: <20170911195644.GA2580@roeck-us.net> References: <1505075825-15700-1-git-send-email-linux@roeck-us.net> <20170911162334.GA13953@kroah.com> <20170911173711.GC27315@roeck-us.net> <20170911182601.GA23199@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170911182601.GA23199@kroah.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 11, 2017 at 11:26:01AM -0700, Greg Kroah-Hartman wrote: > On Mon, Sep 11, 2017 at 10:37:11AM -0700, Guenter Roeck wrote: > > On Mon, Sep 11, 2017 at 09:23:34AM -0700, Greg Kroah-Hartman wrote: > > > On Sun, Sep 10, 2017 at 01:37:01PM -0700, Guenter Roeck wrote: > > > > Commented out code can be added as needed. Drop it. > > > > Also drop TODO and an obsolete XXX comment. > > > > > > > > Signed-off-by: Guenter Roeck > > > > --- > > > > drivers/staging/typec/tcpm.c | 37 +------------------------------------ > > > > 1 file changed, 1 insertion(+), 36 deletions(-) > > > > > > Thans for the series, I'll queue it up once 4.14-rc1 is out and make a > > > branch that can get pulled into both the staging and usb trees, so that > > > future work on this can all happen through the usb tree. > > > > > Should I resend to add the '/**' in patch 3, or can you take care of it ? > > A resend, with -M format, would always be appreciated :) > I did that, as v2, but it does not include the comment change in patch 3. I'll send v3 tonight. Guenter