From: Alan Cox <alan@llwyncelyn.cymru>
To: Vincent Hervieux <vincent.hervieux@gmail.com>
Cc: mchehab@kernel.org, gregkh@linuxfoundation.org,
sakari.ailus@linux.intel.com, hans.verkuil@cisco.com,
rvarsha016@gmail.com, dan.carpenter@oracle.com,
fengguang.wu@intel.com, daeseok.youn@gmail.com,
linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] staging: atomisp: activate ATOMISP2401 support
Date: Tue, 12 Sep 2017 00:25:28 +0100 [thread overview]
Message-ID: <20170912002528.615d0e40@alans-desktop> (raw)
In-Reply-To: <cover.1505142435.git.vincent.hervieux@gmail.com>
On Mon, 11 Sep 2017 20:49:27 +0200
Vincent Hervieux <vincent.hervieux@gmail.com> wrote:
> Currently atomisp module supports Intel's Baytrail SoC and contains
> some compilation switches to support Intel's Cherrytrail SoC instead.
> The patchset aims to :
> - 1/2: activate ATOMISP2400 or ATOMISP2401 from the menu.
> - 2/2: fix compilation errors for ATOMISP2401.
> I'm not so confident with patch 2/2, as it is only working around the non declared functions by using the 2400 path. As I couln't find any declaration/definition for the ISP2401 missing functions...So any help would be appreciated.
> Also patch 2/2 doesn't correct any cosmetic changes reported by checkpatch.pl as explained in TODO step 6.
Please don't. Right now we know what work is to be done and tested.
Alan
prev parent reply other threads:[~2017-09-11 23:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 18:49 [PATCH 0/2] staging: atomisp: activate ATOMISP2401 support Vincent Hervieux
2017-09-11 18:50 ` [PATCH 1/2] staging: atomisp: add menu entries to choose between ATOMISP_2400 and ATOMISP_2401 Vincent Hervieux
2017-09-11 21:08 ` Dan Carpenter
2017-09-11 18:51 ` [PATCH 2/2] staging: atomisp: fix compilation errors in case of ISP2401 Vincent Hervieux
2017-09-11 21:00 ` Dan Carpenter
2017-09-11 23:25 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170912002528.615d0e40@alans-desktop \
--to=alan@llwyncelyn.cymru \
--cc=daeseok.youn@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=fengguang.wu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hans.verkuil@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rvarsha016@gmail.com \
--cc=sakari.ailus@linux.intel.com \
--cc=vincent.hervieux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox