Re: [PATCH v2 3/4] ARM: dts: omap3: Fix Sharp LS037V7DW01 compatible string and envdd supply

Derald D. Woods
2017-09-12T17:33:09Z

On Tue, Sep 12, 2017 at 07:34:46AM -0700, Tony Lindgren wrote:
> * Derald D. Woods <woods.technical@gmail.com> [170911 20:48]:
> > The Sharp panel driver and regulator are now selected properly. This
> > commit eliminates a dummy regulator assignment.
> >
> > Signed-off-by: Derald D. Woods <woods.technical@gmail.com>
> >
> > ---
> > arch/arm/boot/dts/omap3-panel-sharp-ls037v7dw01.dtsi | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/omap3-panel-sharp-ls037v7dw01.dtsi b/arch/arm/boot/dts/omap3-panel-sharp-ls037v7dw01.dtsi
> > index 157345bb8e79..15f73e5adfdf 100644
> > --- a/arch/arm/boot/dts/omap3-panel-sharp-ls037v7dw01.dtsi
> > +++ b/arch/arm/boot/dts/omap3-panel-sharp-ls037v7dw01.dtsi
> > @@ -26,9 +26,10 @@
> > };
> >
> > lcd0: display {
> > - compatible = "sharp,ls037v7dw01";
> > + compatible = "omapdss,sharp,ls037v7dw01";
>
> Is this change needed? I think the driver automatically matches
> even with the "omapdss" part missing?
>

I will check tonight. It is likely something I added when trying various
DSS Kconfig options. I will keep my configuration unchanged and remove
the compatible line change above. If it is just noise, I will send 'v3'
with just 'envdd' supply addition.

Derald

> If it's needed, can you please update the description for why
> it's needed.
>
> Regards,
>
> Tony