From: Guenter Roeck <linux@roeck-us.net>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Yueyao Zhu <yueyao@google.com>,
Badhri Jagan Sridharan <badhri@google.com>,
Hans de Goede <hdegoede@redhat.com>,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v3 1/5] staging: typec: tcpm: Drop commented out code
Date: Tue, 12 Sep 2017 09:41:20 -0700 [thread overview]
Message-ID: <20170912164120.GA7637@roeck-us.net> (raw)
In-Reply-To: <20170912073839.GA18391@kuha.fi.intel.com>
On Tue, Sep 12, 2017 at 10:38:39AM +0300, Heikki Krogerus wrote:
> On Mon, Sep 11, 2017 at 08:32:04PM -0700, Guenter Roeck wrote:
> > Commented out code can be added as needed. Drop it.
> > Also drop TODO and an obsolete XXX comment.
> >
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > ---
> > v2, v3: No change
> >
> > drivers/staging/typec/tcpm.c | 37 +------------------------------------
> > 1 file changed, 1 insertion(+), 36 deletions(-)
>
> Nice! Just to be sure: The idea is to leave tcpci.c in staging, right?
>
Yes, until we get test coverage or Greg gets tired of keeping it there
(in that case we would probably have to drop it).
Guenter
next prev parent reply other threads:[~2017-09-12 16:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 3:32 [PATCH v3 1/5] staging: typec: tcpm: Drop commented out code Guenter Roeck
2017-09-12 3:32 ` [PATCH v3 2/5] staging: typec: tcpm: Document data structures Guenter Roeck
2017-09-12 3:32 ` [PATCH v3 3/5] staging: typec: pd: Document struct pd_message Guenter Roeck
2017-09-12 3:32 ` [PATCH v3 4/5] typec: tcpm: Move out of staging Guenter Roeck
2017-09-12 3:32 ` [PATCH v3 5/5] usb: typec: fusb302: " Guenter Roeck
2017-09-12 7:38 ` [PATCH v3 1/5] staging: typec: tcpm: Drop commented out code Heikki Krogerus
2017-09-12 16:41 ` Guenter Roeck [this message]
2017-09-18 9:06 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170912164120.GA7637@roeck-us.net \
--to=linux@roeck-us.net \
--cc=badhri@google.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=yueyao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox