From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751532AbdILQl0 (ORCPT ); Tue, 12 Sep 2017 12:41:26 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:36455 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751054AbdILQlX (ORCPT ); Tue, 12 Sep 2017 12:41:23 -0400 X-Google-Smtp-Source: ADKCNb5Kx7L4mcwHjfLeY5WIKtrLdDvdwHp8s+Fb5hmn1p4xfC23Bz1mzjpnDnSlLSPBjnzIXhzt7g== Date: Tue, 12 Sep 2017 09:41:20 -0700 From: Guenter Roeck To: Heikki Krogerus Cc: Greg Kroah-Hartman , Yueyao Zhu , Badhri Jagan Sridharan , Hans de Goede , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v3 1/5] staging: typec: tcpm: Drop commented out code Message-ID: <20170912164120.GA7637@roeck-us.net> References: <1505187128-5459-1-git-send-email-linux@roeck-us.net> <20170912073839.GA18391@kuha.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170912073839.GA18391@kuha.fi.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 12, 2017 at 10:38:39AM +0300, Heikki Krogerus wrote: > On Mon, Sep 11, 2017 at 08:32:04PM -0700, Guenter Roeck wrote: > > Commented out code can be added as needed. Drop it. > > Also drop TODO and an obsolete XXX comment. > > > > Signed-off-by: Guenter Roeck > > --- > > v2, v3: No change > > > > drivers/staging/typec/tcpm.c | 37 +------------------------------------ > > 1 file changed, 1 insertion(+), 36 deletions(-) > > Nice! Just to be sure: The idea is to leave tcpci.c in staging, right? > Yes, until we get test coverage or Greg gets tired of keeping it there (in that case we would probably have to drop it). Guenter