From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752012AbdIMSw4 (ORCPT ); Wed, 13 Sep 2017 14:52:56 -0400 Received: from mga01.intel.com ([192.55.52.88]:28254 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751983AbdIMSwx (ORCPT ); Wed, 13 Sep 2017 14:52:53 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,389,1500966000"; d="scan'208";a="1218399210" Date: Wed, 13 Sep 2017 11:52:40 -0700 From: Jarkko Sakkinen To: tpmdd-devel@lists.sourceforge.net Cc: linux-security-module@vger.kernel.org, Peter Huewe , Marcel Selhorst , Jason Gunthorpe , open list Subject: Re: [PATCH 3/3] tpm: fix type of a local variables in tpm_tis_spi.c Message-ID: <20170913185240.wgzdlzeuc3fhf7fb@linux.intel.com> References: <20170913172654.25036-1-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170913172654.25036-1-jarkko.sakkinen@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applied (as other similar) already to master because these are very obvious things to fix. I'll wait for reviews and tests before applying to next. /Jarkko On Wed, Sep 13, 2017 at 10:26:54AM -0700, Jarkko Sakkinen wrote: > Use __le32 type for data in that format. > > Fixes: 0edbfea537d1 ("tpm/tpm_tis_spi: Add support for spi phy") > Signed-off-by: Jarkko Sakkinen > --- > drivers/char/tpm/tpm_tis_spi.c | 25 ++++++++++++++++++------- > 1 file changed, 18 insertions(+), 7 deletions(-) > > diff --git a/drivers/char/tpm/tpm_tis_spi.c b/drivers/char/tpm/tpm_tis_spi.c > index 7e97eb07b200..bfe972959183 100644 > --- a/drivers/char/tpm/tpm_tis_spi.c > +++ b/drivers/char/tpm/tpm_tis_spi.c > @@ -153,29 +153,40 @@ static int tpm_tis_spi_write_bytes(struct tpm_tis_data *data, u32 addr, > > static int tpm_tis_spi_read16(struct tpm_tis_data *data, u32 addr, u16 *result) > { > + __le16 result_le; > int rc; > > - rc = data->phy_ops->read_bytes(data, addr, sizeof(u16), (u8 *)result); > + rc = data->phy_ops->read_bytes(data, addr, sizeof(u16), > + (u8 *)&result_le); > if (!rc) > - *result = le16_to_cpu(*result); > + *result = le16_to_cpu(result_le); > + > return rc; > } > > static int tpm_tis_spi_read32(struct tpm_tis_data *data, u32 addr, u32 *result) > { > + __le32 result_le; > int rc; > > - rc = data->phy_ops->read_bytes(data, addr, sizeof(u32), (u8 *)result); > + rc = data->phy_ops->read_bytes(data, addr, sizeof(u32), > + (u8 *)&result_le); > if (!rc) > - *result = le32_to_cpu(*result); > + *result = le32_to_cpu(result_le); > + > return rc; > } > > static int tpm_tis_spi_write32(struct tpm_tis_data *data, u32 addr, u32 value) > { > - value = cpu_to_le32(value); > - return data->phy_ops->write_bytes(data, addr, sizeof(u32), > - (u8 *)&value); > + __le32 value_le; > + int rc; > + > + value_le = cpu_to_le32(value); > + rc = data->phy_ops->write_bytes(data, addr, sizeof(u32), > + (u8 *)&value_le); > + > + return rc; > } > > static const struct tpm_tis_phy_ops tpm_spi_phy_ops = { > -- > 2.14.1 >