From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751424AbdIMV36 (ORCPT ); Wed, 13 Sep 2017 17:29:58 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:45016 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751137AbdIMV3z (ORCPT ); Wed, 13 Sep 2017 17:29:55 -0400 Date: Wed, 13 Sep 2017 14:29:52 -0700 From: Greg KH To: Lars-Peter Clausen Cc: Jonathan Cameron , devel@driverdev.osuosl.org, daniel.baluta@gmail.com, pmeerw@pmeerw.net, Michael.Hennerich@analog.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, nick.desaulniers@gmail.com, outreachy-kernel@googlegroups.com, Himanshi Jain , knaack.h@gmx.de Subject: Re: [PATCH v2 1/2] include: linux: sysfs: Add __ATTR_NAMED macro Message-ID: <20170913212952.GD9288@kroah.com> References: <2bc7a124ab925dd2c50aa8c778745d179777d50d.1505291907.git.himshijain.hj@gmail.com> <20170913180310.27cbf1b1@archlinux> <20170913185805.GB26390@kroah.com> <5e43ea4d-eab8-c4be-c5dc-2f862578d011@metafoo.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5e43ea4d-eab8-c4be-c5dc-2f862578d011@metafoo.de> User-Agent: Mutt/1.9.0 (2017-09-02) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 13, 2017 at 09:23:31PM +0200, Lars-Peter Clausen wrote: > On 09/13/2017 08:58 PM, Greg KH wrote: > > On Wed, Sep 13, 2017 at 06:03:10PM +0100, Jonathan Cameron wrote: > >> On Wed, 13 Sep 2017 14:14:07 +0530 > >> Himanshi Jain wrote: > >> > >>> Add __ATTR_NAMED macro similar to __ATTR but taking name as a > >>> string instead of implicit conversion of argument to string using > >>> the macro _stringify(_name). > >>> > >>> Signed-off-by: Himanshi Jain > >>> --- > >>> include/linux/sysfs.h | 7 +++++++ > >>> 1 file changed, 7 insertions(+) > >>> > >>> diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h > >>> index aa02c32..20321cf 100644 > >>> --- a/include/linux/sysfs.h > >>> +++ b/include/linux/sysfs.h > >>> @@ -104,6 +104,13 @@ struct attribute_group { > >>> .store = _store, \ > >>> } > >>> > >>> +#define __ATTR_NAMED(_name, _mode, _show, _store) { \ > >> > >> I'm not sure about the naming here. The normal __ATTR macro is also > >> 'named'. Maybe something as awful as > >> > >> __ATTR_STRING_NAME ? > >> > >> Greg what do you think? > > > > ick ick ick. > > > >> This is all to allow us to have names with operators in them without > >> checkpatch complaining about them... A worthwhile aim just to stop > >> more people wasting time trying to 'fix' those cases by adding spaces. > > > > Yeah, but this really seems "heavy" for just a crazy sysfs name in a > > macro. Adding a whole new "core" define for that is a hard sell... > > > > I also want to get rid of the "generic" __ATTR type macros, and force > > people to use the proper _RW and friends instead. I don't want to add > > another new one that people will start to use that I later have to > > change... > > > > So no, I don't like this, how about just changing your macros instead? > > No one else has this problem :) > > Nobody else realized they have this problem yet. E.g. there are a few users > of __ATTR in block/genhd.c that have the same issue and are likely to > generate the same false positives from static checkers. Then fix the broken static checkers :)