From: Tejun Heo <tj@kernel.org>
To: Shaohua Li <shli@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
lizefan@huawei.com, tglx@linutronix.de, kernel-team@fb.com,
axboe@kernel.dk, Shaohua Li <shli@fb.com>
Subject: Re: [PATCH V2 1/4] kthread: add a mechanism to store cgroup info
Date: Wed, 13 Sep 2017 14:43:08 -0700 [thread overview]
Message-ID: <20170913214308.GE378890@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <20170913213820.GA378890@devbig577.frc2.facebook.com>
On Wed, Sep 13, 2017 at 02:38:20PM -0700, Tejun Heo wrote:
> Maybe doing sth like the following is less error-prone?
>
> kthread_associate_blkcg(@css)
> {
> if (current's kthread->blkcg_css)
> put kthread->blkcg_css and set it to NULL;
> if (@css)
> get @css and set kthread->blkcg;
> }
Ooh, also, maybe add a WARN_ON_ONCE on non-NULL blkcg_css on kthread
exit?
Thanks.
--
tejun
next prev parent reply other threads:[~2017-09-13 21:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 21:01 [PATCH V2 0/4] block: make loop block device cgroup aware Shaohua Li
2017-09-13 21:01 ` [PATCH V2 1/4] kthread: add a mechanism to store cgroup info Shaohua Li
2017-09-13 21:38 ` Tejun Heo
2017-09-13 21:43 ` Tejun Heo [this message]
2017-09-13 22:30 ` Shaohua Li
2017-09-13 21:01 ` [PATCH V2 2/4] blkcg: delete unused APIs Shaohua Li
2017-09-13 21:40 ` Tejun Heo
2017-09-13 21:01 ` [PATCH V2 3/4] block: make blkcg aware of kthread stored original cgroup info Shaohua Li
2017-09-13 21:42 ` Tejun Heo
2017-09-13 21:01 ` [PATCH V2 4/4] block/loop: make loop cgroup aware Shaohua Li
2017-09-13 21:42 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170913214308.GE378890@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=shli@fb.com \
--cc=shli@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox