From: Sherry Yang <sherryy@android.com>
To: linux-kernel@vger.kernel.org
Cc: tkjos@google.com, maco@google.com, arve@android.com,
gregkh@linuxfoundation.org, Sherry Yang <sherryy@android.com>,
Ingo Molnar <mingo@kernel.org>, Michal Hocko <mhocko@suse.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
David Rientjes <rientjes@google.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andy Lutomirski <luto@kernel.org>,
Oleg Nesterov <oleg@redhat.com>, Hoeun Ryu <hoeun.ryu@gmail.com>,
Christoph Lameter <cl@linux.com>,
Vegard Nossum <vegard.nossum@oracle.com>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: [PATCH] mm: Restore mmput_async
Date: Wed, 13 Sep 2017 17:59:27 -0400 [thread overview]
Message-ID: <20170913215932.86846-1-sherryy@android.com> (raw)
In-Reply-To: <20170908223934.67442-1-sherryy@android.com>
Restore asynchronous mmput, allowing mmput_async to be called
from an atomic context in Android binder shrinker callback.
mmput_async was initially introduced in ec8d7c14e
("mm, oom_reaper: do not mmput synchronously from the
oom reaper context"), and was removed in 212925802
("mm: oom: let oom_reap_task and exit_mmap run concurrently")
Signed-off-by: Sherry Yang <sherryy@android.com>
---
include/linux/sched/mm.h | 6 ++++++
kernel/fork.c | 18 ++++++++++++++++++
2 files changed, 24 insertions(+)
diff --git a/include/linux/sched/mm.h b/include/linux/sched/mm.h
index 3a19c253bdb1..ae53e413fb13 100644
--- a/include/linux/sched/mm.h
+++ b/include/linux/sched/mm.h
@@ -84,6 +84,12 @@ static inline bool mmget_not_zero(struct mm_struct *mm)
/* mmput gets rid of the mappings and all user-space */
extern void mmput(struct mm_struct *);
+#ifdef CONFIG_MMU
+/* same as above but performs the slow path from the async context. Can
+ * be called from the atomic context as well
+ */
+void mmput_async(struct mm_struct *);
+#endif
/* Grab a reference to a task's mm, if it is not already going away */
extern struct mm_struct *get_task_mm(struct task_struct *task);
diff --git a/kernel/fork.c b/kernel/fork.c
index 10646182440f..e702cb9ffbd8 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -946,6 +946,24 @@ void mmput(struct mm_struct *mm)
}
EXPORT_SYMBOL_GPL(mmput);
+#ifdef CONFIG_MMU
+static void mmput_async_fn(struct work_struct *work)
+{
+ struct mm_struct *mm = container_of(work, struct mm_struct,
+ async_put_work);
+
+ __mmput(mm);
+}
+
+void mmput_async(struct mm_struct *mm)
+{
+ if (atomic_dec_and_test(&mm->mm_users)) {
+ INIT_WORK(&mm->async_put_work, mmput_async_fn);
+ schedule_work(&mm->async_put_work);
+ }
+}
+#endif
+
/**
* set_mm_exe_file - change a reference to the mm's executable file
*
--
2.11.0 (Apple Git-81)
next prev parent reply other threads:[~2017-09-13 21:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 22:39 [PATCH] android: binder: Drop lru lock in isolate callback Sherry Yang
2017-09-13 21:59 ` Sherry Yang [this message]
2017-09-13 22:09 ` [PATCH] mm: Restore mmput_async Andrew Morton
2017-09-13 22:44 ` Sherry Yang
2017-09-13 22:57 ` Andrew Morton
2017-09-14 0:08 ` Arve Hjønnevåg
2017-09-14 8:19 ` Michal Hocko
2017-09-14 18:22 ` [PATCH v2] android: binder: Drop lru lock in isolate callback Sherry Yang
2017-09-14 20:12 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170913215932.86846-1-sherryy@android.com \
--to=sherryy@android.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=arve@android.com \
--cc=cl@linux.com \
--cc=fweisbec@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hoeun.ryu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=maco@google.com \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=tkjos@google.com \
--cc=vbabka@suse.cz \
--cc=vegard.nossum@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox