From: Baoquan He <bhe@redhat.com>
To: linux-kernel@vger.kernel.org, x86@kernel.org
Cc: mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com,
thgarnie@google.com, keescook@chromium.org,
akpm@linux-foundation.org, yamada.masahiro@socionext.com,
rja@hpe.com, frank.ramsay@hpe.com
Subject: Re: [PATCH v2 RESEND 0/2] x86/mm/KASLR: Do not adapt the size of the direct mapping section for SGI UV system
Date: Thu, 14 Sep 2017 09:44:51 +0800 [thread overview]
Message-ID: <20170914014451.GK12824@x1> (raw)
In-Reply-To: <1504770150-25456-1-git-send-email-bhe@redhat.com>
Hi all,
PING!
Do anyone has any suggestion about this issue? This bug blocks SGI
system's boot, KASLR has to be disabled on SGI system if they want to
run tests.
Thanks
Baoquan
On 09/07/17 at 03:42pm, Baoquan He wrote:
> This is v2 post RESEND. Add Mike's Acked-by to patch 2/2 as he suggested
> in private mail. And update patches log slightly.
>
> This patchset is trying to fix a bug that SGI UV system casually hang
> during boot with KASLR enabled. The root cause is that mm KASLR adapts
> size of the direct mapping section only based on the system RAM size.
> Then later when map SGI UV MMIOH region into the direct mapping during
> rest_init() invocation, it might go beyond of the directing mapping
> section and step into VMALLOC or VMEMMAP area, then BUG_ON triggered.
>
> The fix is adding a helper function is_early_uv_system to check UV system
> earlier, then call the helper function in kernel_randomize_memory() to
> check if it's a SGI UV system, if yes, we keep the size of direct mapping
> section to be 64TB just as nokslr.
>
> With this fix, SGI UV system can have 64TB direct mapping size always,
> and the starting address of direct mapping/vmalloc/vmemmap and the padding
> between them can still be randomized to enhance the system security.
>
> v1->v2:
> 1. Mike suggested making is_early_uv_system() an inline function and be
> put in include/asm/uv/uv.h so that they can adjust them easier in the
> future.
>
> 2. Split the v1 code into uv part and mm KASLR part as Mike suggested.
>
> Baoquan He (2):
> x86/UV: Introduce a helper function to check UV system at earlier
> stage
> x86/mm/KASLR: Do not adapt the size of the direct mapping section for
> SGI UV system
>
> arch/x86/include/asm/uv/uv.h | 6 ++++++
> arch/x86/mm/kaslr.c | 3 ++-
> 2 files changed, 8 insertions(+), 1 deletion(-)
>
> --
> 2.5.5
>
prev parent reply other threads:[~2017-09-14 1:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 7:42 [PATCH v2 RESEND 0/2] x86/mm/KASLR: Do not adapt the size of the direct mapping section for SGI UV system Baoquan He
2017-09-07 7:42 ` [PATCH v2 RESEND 1/2] x86/UV: Introduce a helper function to check UV system at earlier stage Baoquan He
2017-09-14 7:29 ` Baoquan He
2017-09-14 7:49 ` Dave Young
2017-09-14 8:08 ` Baoquan He
2017-09-15 0:47 ` Dave Young
2017-09-15 0:55 ` Dave Young
2017-09-07 7:42 ` [PATCH v2 RESEND 2/2] x86/mm/KASLR: Do not adapt the size of the direct mapping section for SGI UV system Baoquan He
2017-09-28 7:56 ` Ingo Molnar
2017-09-28 8:31 ` Baoquan He
2017-09-28 9:01 ` Ingo Molnar
2017-09-28 14:10 ` Mike Travis
2017-09-30 11:25 ` Baoquan He
2018-05-17 3:18 ` Baoquan He
2018-05-17 15:06 ` Ramsay, Frank
2018-05-17 15:47 ` Mike Travis
[not found] ` <53301a1e-e817-912f-cf7d-0000b078c7a3@hpe.com>
[not found] ` <20180523000306.GY24627@MiWiFi-R3L-srv>
[not found] ` <7ce3cc80-3991-f914-c539-9fa38256ea4b@hpe.com>
2018-05-31 3:26 ` Baoquan He
2017-09-14 1:44 ` Baoquan He [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170914014451.GK12824@x1 \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=frank.ramsay@hpe.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rja@hpe.com \
--cc=tglx@linutronix.de \
--cc=thgarnie@google.com \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox